Pierre-Sassoulas / pySankey

This is the maintened version of PySankey (pySankeyBeta on Pypi)
GNU General Public License v3.0
37 stars 8 forks source link

Changed syntax of line 51 #3

Closed kenosborne closed 5 years ago

kenosborne commented 5 years ago

The syntax before the pull is if len(labels > 0): . It seems unreliable and / or wrong.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 40


Changes Missing Coverage Covered Lines Changed/Added Lines %
pysankey/sankey.py 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Totals Coverage Status
Change from base Build 39: -86.8%
Covered Lines: 0
Relevant Lines: 2

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 40


Changes Missing Coverage Covered Lines Changed/Added Lines %
pysankey/sankey.py 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Totals Coverage Status
Change from base Build 39: -86.8%
Covered Lines: 0
Relevant Lines: 2

💛 - Coveralls
Pierre-Sassoulas commented 5 years ago

Thank you for the catch, I probably did not see this when it was introduced.