search

PierreGode / MMM-PhoneDetect

Detect if phones or devices are in network and turns on and off mirror display.
MIT License
6 stars 3 forks source link

Review #2

Closed KristjanESPERANTO closed 11 months ago

KristjanESPERANTO commented 11 months ago

Thanks again for the module. I had a look at the code and have a few suggestions for cosmetic changes:

No functional changes.

KristjanESPERANTO commented 11 months ago

Nice. Now your screenshot is also displayed on the module list.

In the screenshot, the dots at the bottom right belong to the module and the lines above to another, right?

PierreGode commented 11 months ago

Thank you.Yes the PhoneDetect Will only show a dot for each device configured in the config, no lines no fuzz just the dots./Pierre Gode6 jan. 2024 kl. 12:37 skrev Kristjan ESPERANTO @.***>: Nice. Now your screenshot is also displayed on the module list. In the screenshot, the dots at the bottom right belong to the module and the lines above to another, right?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

KristjanESPERANTO commented 11 months ago

I somehow overlooked it in the README, but have now found it: "represented as dots".

I think it's nicely discreet :+1:

PierreGode commented 11 months ago

Hi. Thank you!One other thing I have more modules in the magic mirror modules list. If you want and can you are welcome to take a look at those who at least have potential to be popular.PierreGode/MMM-next-episode: Magic mirror module for TV shows and movies with next-episode. Track the TV show and movies you watch.github.comPierreGode/MMM-ZAPTEC: MMM-ZAPTEC module displays ZAPTEC charger data and charge history on MagicMirror. It supports multiple chargers and customizable settings like language and update interval.github.com/Pierre Gode6 jan. 2024 kl. 12:57 skrev Kristjan ESPERANTO @.***>: I somehow overlooked it in the README, but have now found it: "represented as dots". I think it's nicely discreet 👍

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

KristjanESPERANTO commented 11 months ago

Okay, I took a quick look. For optimal presentation on the new module list the same things are missing at all of your other your modules:

  1. package.json file: That's e.g. necessary for the keywords/tags.
  2. the screenshot has to be directly in the repository.

There are other issues as well (check out this list), but for the module list only the two mentioned points are important.