search

PierrePaul / html5-dopetrope

Pelican theme based on html5-dopetrope design.
Other
58 stars 17 forks source link

config.js does not take from SITE_URL #14

Closed Bamieh closed 7 years ago

Bamieh commented 7 years ago

hey buddy,

First i would like to thank you for the amazing job with the template.

As the name suggests, there is a bug that skel_configs do not take from the SITE_URL config. to fix this i added the following locally:

<!-- templates/base.html -->
<script>
   window.SITEURL = "{{SITEURL}}"
</script>
// static/js/config.js
window._skel_config = {
   ...,
   prefix: `${window.SITEURL}theme/css/style`,
   ...,
}

what do you think about this? if we're on the same page i can submit a pull request for you

cheers!

PierrePaul commented 7 years ago

Hey, sorry for the long wait. You're totally right. I've made the changes and gave you credit for it :) Thanks!

Bamieh commented 7 years ago

thank you!