search

PierreRochard / bitcoin-acks

https://BitcoinACKs.com
MIT License
19 stars 7 forks source link

ACK appears as stale ACK #82

Open jonatack opened 5 years ago

jonatack commented 5 years ago

The ACK here is parsed as a stale ACK.

Related to fixed issue #76? Perhaps stale status should also require new commits to exist further down in the HTML than the ACK if it doesn't provide a commit hash (hacky, I know).

PierreRochard commented 5 years ago

Thanks for reporting this @jonatack, that's definitely a feasible solution using the timeline items graphql api https://developer.github.com/v4/union/pullrequesttimelineitems/

I'll come back to this asap!