search

PierreRochard / bitcoin-acks

https://BitcoinACKs.com
MIT License
19 stars 7 forks source link

Update legend to align with current Bitcoin Core review guidelines #88

Open michaelfolkson opened 4 years ago

michaelfolkson commented 4 years ago

Posting this in case someone else gets to this before I do.

Currently bitcoinacks.com has a legend of Concept ACK, Tested ACK, Stale Tested ACK, utACK, Stale utACK, NACK.

The Bitcoin Core review guidelines were updated last year and now encourage use of Concept (N)ACK, Approach (N)ACK and ACK branch_commit.

To follow these guidelines we need to ditch Tested ACK, Stale Tested ACK, utACK, Stale utACK in the legend and introduce Approach ACK, ACK commit, Stale ACK commit.

(Of course reviewers are still encouraged to describe what testing they have done in their review. But in a descriptive comment rather than standardized use of tACK, utACK. We could perhaps monitor whether the reviewer mentions "test" in their comment. But I'm leaning towards not as reviewer could state something "Did not test" and it might be wrongly flagged as the equivalent of a tACK)

michaelfolkson commented 4 years ago

Here is the Bitcoin Core PR that made the changes to the review guidelines effectively deprecating tACK and utACK.