Add a flag to append a fixed HTTP header to all responses.

PierreZ / goStatic

A really small static web server for Docker

GNU General Public License v2.0

391 stars 77 forks source link

Add a flag to append a fixed HTTP header to all responses. #3

Closed gomlgs closed 7 years ago

gomlgs commented 7 years ago

Note: The latest centurylink/golang-builder image does not build this project because of Golang 1.7 dependencies; I used a local build.

I also had to fix the echo.Run calls which have changed to echo.Start.

PierreZ commented 7 years ago

Hi, thanks for your interest for GoStatic. I wasn't aware that people other than me was using goStatic, and then I saw DockerHub stats. I'm currently rewriting a new version. Why do you need to add headers?

gomlgs commented 7 years ago

Thanks a lot for developing this! Regarding headers, I wanted to add some default caching headers to all responses.

PierreZ commented 7 years ago

Due to complete rewrite on my side, can you upgrade your PR? I looked over your code, it should be easy to adapt it to the new version. Don't hesitate to ping me if you're having trouble.

gomlgs commented 7 years ago

Done.

PierreZ commented 7 years ago

Merged. Thanks for the PR!