Update ci.yml - Githubissues

PieterTack / polycap

Polycapillary X-ray raytracing

GNU General Public License v3.0

3 stars 3 forks source link

Update ci.yml #68

Closed PieterTack closed 1 year ago

PieterTack commented 1 year ago

So as far as I understood, meson never uses Automake.am files, so I went through all directories and removed them. Also configure.ac shouldn't be used by meson, so got rid of that. Then I made some changes to the ci.yml... There are a few lines of code that I'm not sure about.... I added some comments there.

PieterTack commented 1 year ago

In 'ci.yml', in build msys2/setup-msys2@v2; is it safe to remove make etc here as well? I guess not, as it is then used to make xraylib etc? Or can we do this differently on msys2 as well?

PieterTack commented 1 year ago

Status note:

visual studio: "found pkg-config 'C:\Strawberry\perl\bin\pkg-config.BAT' but it is Strawberry Perl and thus broken. Ignoring..." --> how does one properly install pkg-config on windows system/visualstudio?
ubuntu:latest: " OpenMP found but omp.h missing." --> somehow meson setup does not find omp.h... From what I find I should add the -fopenmp flag during compilation, but as this isn't the compilation step yet I'm not understanding the problem at hand. Probably a path is missing somewhere? But why, as I think before this all this wasn't an issue for ubuntu systems?

tschoonj commented 1 year ago

@PieterTack I got the visual studio build working after a lot of trial and error. Would be great if you could review if you have a moment.

tschoonj commented 1 year ago

Note that this PR already includes the changes necessary to support HDF5 1.14, as this version is in use by both msys2 and vcpkg.