search

Pietrucci-Blacher / notion-snap-reborn

Remake of Notion-snap
65 stars 5 forks source link

Upgradation of this snap #69

Open soumyaDghosh opened 11 months ago

soumyaDghosh commented 11 months ago

We can improve this snap and I can't find any reason to use electron builder. Also, we should ask for the name notion, duplication is never expected. You should initiate this in the forum. I can help you make a snap manifest.

Pietrucci-Blacher commented 11 months ago

Hi 👋, thank you for your offer to help me, is it a matter of updating the CI pipeline to use an upload via manifest or to perform an update work in order to use other thing than Electron (it seems complicated to me 🤔)? However, I don't see how that having the name "notion" is not good since the tag is not the same as the other applications and this one is well referenced on the snapstore.

soumyaDghosh commented 11 months ago

Answering one by one:

  1. Currently the snap is built using the electron builder but what I propose is, using a snapcraft.yaml and make, upload the snap by linking this repo to the snapcraft builder website.
  2. As the snap is registered as notion-snap-reborn, in future it'll be tough to present this to the upstream, they would like the have the name notion itself. So, I suggest if the snap is currently not very actively used by many users i.e for me it's more than 100 users, we should register the name notion, make a proper snap, with latest core22 and gnome extension and try to present it to the upstream.
Pietrucci-Blacher commented 11 months ago

Hi, sorry for the wait for a reply, I've been a bit busy. I've already tried before to make a production release via snapcraft.yaml but what a pain especially at the documentation level, it's true that I'd love a helping hand (I invite you to open a PR as soon as it's ready 😉).

Pietrucci-Blacher commented 11 months ago

Hi @soumyaDghosh, any updates ? 😎

soumyaDghosh commented 11 months ago

I am sorry, very busy these days. I am trying to create one just now.

soumyaDghosh commented 11 months ago

Hi... I am sorry, I didn't do much research back when I created this issue. But, just now I did, and looks like there is no official app for notion in linux. There is this unofficial app though. This looks promising.

https://github.com/notion-enhancer/notion-repackaged

But, though I am wrong regarding a custom manifest instead electron-builder. We can still improve the current one. like adding these keys:

  1. base = core22
  2. allowNativeWayland = True
  3. compression = lzo

Can you make a test snap with these?

Pietrucci-Blacher commented 6 months ago

135