PiggyArchive / PiggyAuth

Safe & feature-rich auth plugin. Project has been discontinued
Apache License 2.0
33 stars 8 forks source link

Todo for 2.0.1 (Big update, comment features requests & issues!!!) #10

Closed DaPigGuy closed 7 years ago

DaPigGuy commented 7 years ago

Features/Tweaks

Issues

fycarman commented 7 years ago

Serverauth to piggyauth importer! :)

Aericio commented 7 years ago

Block people from registering/logging in with explicit names.

DaPigGuy commented 7 years ago

@Aericio Okay, added to to-do list.

Aericio commented 7 years ago

Only show "There has been (X) attempts to login into your account" if someone has tried to login so it doesn't always show on login.

DaPigGuy commented 7 years ago

Added to to-do list.

Aericio commented 7 years ago

Allow option to disable pin for certain players. For example, if owner's pin is found out, there goes your whole server. Don't got a backup? Your dead.

NyaomiDEV commented 7 years ago

@MCPEPIG WE WANT MORE BACON

Adam1609 commented 7 years ago

SimpleAuthTransfer to PiggyAuth? Would be possible?

DaPigGuy commented 7 years ago

I think converting isnt needed as password_verify also does SHA256 and thats what simpleauth uses.

DaPigGuy commented 7 years ago

@Aerico Added.

DaPigGuy commented 7 years ago

Will work on this later.

DaPigGuy commented 7 years ago

Update to the latest version to stop the errors!

DaPigGuy commented 7 years ago

Update to the latest version. Fixes a very bad issue & also fixes incompatibility issues for Genisys users.

ghost commented 7 years ago

Hi, I expect MD5 support.

DaPigGuy commented 7 years ago

@Harviy MD5 is bad.

Aericio commented 7 years ago

Check if the user's password is the same as the username.

SuperKali commented 7 years ago

cattura41 bug

when I died the food not from

Aericio commented 7 years ago

When you die, your food doesn't go back?

SuperKali commented 7 years ago

@Aericio Yes Another bug What I noticed and that if the player enters, does not find anything in the inventory

DaPigGuy commented 7 years ago

That's not a bug, it's an option which hides inventory til logged in. You can turn it off in config.

DaPigGuy commented 7 years ago

Fixed the problem with hunger.

DaPigGuy commented 7 years ago

@Aerico Done.

Aericio commented 7 years ago

Make an option to force certain people to login with Xbox. Extra security for server owners or OPs

Thunder33345 commented 7 years ago

proposal: regex blocking for name and password proposal: more then steve bypass, allows owner to configure accounts to be bypassed proposal: a more hierarchy config like https://github.com/PEMapModder/HereAuth/blob/master/resources/config.yml allows user to easily navigate

DaPigGuy commented 7 years ago

1 & 2 I will do, 3 I might add in the next update.

Thunder33345 commented 7 years ago

after looking through source code i suggest

https://github.com/MCPEPIG/PiggyAuth/blob/master/src/PiggyAuth/Databases/MySQL.php#L42 changing return to PlayerDataObject instate of using arrays, it helps other developers reading the source code

https://github.com/MCPEPIG/PiggyAuth/blob/master/src/PiggyAuth/Main.php#L407 adding a hashing cost config (there a hash cost option http://php.net/manual/en/function.password-hash.php)

I have seen the whole email failing thing i suggest a mailer support, like using MailGun, local mail(), or a relay mail web sever (like how it is currently) for now at least add a config for mailserver URL allowing owner to host their own if they wish so adding a optional &key=secretpassword allows owner to keep that for their own use if they desire so

also i think you should make use of the projects feature

Thunder33345 commented 7 years ago

I never understand the concept of a owner key what is it for? to allow owner to forcelogin to any players without password?

DaPigGuy commented 7 years ago

Planned release for 2.0.1 will be mid-April Moved importing databases to next update.

Aericio commented 7 years ago

ay, heres ye boi with the latest bugs that i found. good luck, oink! 🐷🐷🐷







Error:

Notice: Undefined variable: password in phar:///home/gmplus/Server/plugins/PiggyAuth.phar/src/PiggyAuth/Main.php on line 571

Notice: Undefined variable: password in phar:///home/gmplus/Server/plugins/PiggyAuth.phar/src/PiggyAuth/Main.php on line 576

Notice: Undefined variable: password in phar:///home/gmplus/Server/plugins/PiggyAuth.phar/src/PiggyAuth/Main.php on line 576

Notice: Undefined index: ip in phar:///home/gmplus/Server/plugins/PiggyAuth.phar/src/PiggyAuth/Databases/MySQL.php on line 98
DaPigGuy commented 7 years ago

Should be all fixed.

Aericio commented 7 years ago

/changemail doesn't get errors now, but it still doesn't change.

DaPigGuy commented 7 years ago

Run this: "ALTER TABLE players ADD COLUMN ip VARCHAR(32)"

Thunder33345 commented 7 years ago

Save data in player.dat

What does that means? i dont think injecting hashing data into player.dat is a good idea, at least a toggle option would be prefered

also you should create a usage wiki this plugin is getting quite big with a lot of features and so on

DaPigGuy commented 7 years ago

Save hashed passwords & stuff

DaPigGuy commented 7 years ago

I've added a MailGun & database page. What else? Also, you can contribute to it.

Aericio commented 7 years ago

I made the wiki sexier :3

Aericio commented 7 years ago

FEATURE REQUEST: If someone LOGS IN to someone's account from a new ip address, send an email to tell them that someone has logged in, not ATTEMPTED (unless you want it like that too, but this is kinda like what most people do, ex: twitter)

Thunder33345 commented 7 years ago

as for saving hashes into player.dat, i still fail to see why that would been better?

maybe we are getting too ahead of our self but, option to toggle email and toggle per notification settings

DaPigGuy commented 7 years ago

I'll add a toggle for email later. And notifications as in emails?

Thunder33345 commented 7 years ago

i also tried to implement regex support which ended up with a flop on unexpected logic error(which i intended it to be regex white list :facepalm:) main question is accidentally reformatted the whole code to my own code style (derp) https://github.com/Thunder33345/PiggyAuth/commit/f0c35ec288f1771677c14ca2afee55d71946662c do i need to redone or your ide is capable to reformatting it back into your code style when we merge, or github will sort it for us?

DaPigGuy commented 7 years ago

Reformat

ghost commented 7 years ago

Add something like if player is not registered or logged in, it gets random username, for example Player1, Player2, etc. and it can do everything like normal player but it will not can execute commands? I hope I was clear enough. (Like on LBSG.)

ghost commented 7 years ago

Thanks Aericio.

Aericio commented 7 years ago

causes chat to lag when used on TesserREKT.

ghost commented 7 years ago

On pmmp (PocketMine-MP) too.

DaPigGuy commented 7 years ago

Temporarily fixed. Need a way to add back password checking for messages without lag.

ghost commented 7 years ago

:/

SleepSpace9 commented 7 years ago

Because pmmp has no core feature for banning CIDs (and Genisys is discontinued) maybe this could be a new feature of PiggyAuth. By the way I don't know whether somebody already did a request for that at pmmp.

Thunder33345 commented 7 years ago

what feature?

SleepSpace9 commented 7 years ago

Banning ClientIDs