PiggyArchive / PiggyAuth

Safe & feature-rich auth plugin. Project has been discontinued
Apache License 2.0
33 stars 8 forks source link

Todo for 3.0.0 Rewrite #39

Open DaPigGuy opened 7 years ago

DaPigGuy commented 7 years ago

PROJECT DISCONTINUED - if you with to for these to be implemented, please create PR's and add them by yourself.

Thunder33345 commented 7 years ago

should class fy and API fy the email verifier and sender and relateds to provide future compatibility when we add more mail supports you should also consider using the projects page https://github.com/MCPEPIG/PiggyAuth/projects

Thunder33345 commented 7 years ago

I think something NEEDS to be done on forget password reset using pin https://github.com/MCPEPIG/PiggyAuth/blob/a7ccdb62ad701df875bb56e2f8eb308545596b8e/src/PiggyAuth/Main.php#L596 someone WILL come along and brute force the pins so i highly recommend you to just allow owner to disable pin completely for the sake of server security

DaPigGuy commented 7 years ago

@Thunder33345 I'll add tries like for logging in.

SalmonDE commented 7 years ago

Addition: More typehints and return types