search

Pigpog / vlc-discord-rpc

Discord rich presence for VLC media player.
MIT License
207 stars 31 forks source link

If I close VLC while playing it still running in discord #40

Closed excap3r closed 4 years ago

excap3r commented 4 years ago

Describe the bug If I close VLC while playing any media it is still showing up in Discord, using detached mode.

To Reproduce Steps to reproduce the behavior:

  1. Play media on VLC
  2. Start script
  3. Close VLC
  4. Discord still showing that media is playing

Terminal output 0|app | Error: connect ECONNREFUSED 127.0.0.1:8080 0|app | at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1128:14) { 0|app | errno: 'ECONNREFUSED', 0|app | code: 'ECONNREFUSED', 0|app | syscall: 'connect', 0|app | address: '127.0.0.1', 0|app | port: 8080 0|app | }

Your Setup:

Additional context I temporary fixed it by editing error handler on diff.js and now working fine :) I love this feature and I'm looking forward for the VLC Extension, good work, keep it up👍

Code changed: diff.js, line 57: .catch((err) => { last.state = "stopped"; callback(last, false); });

Pigpog commented 4 years ago

This was fixed in https://github.com/Pigpog/vlc-discord-rpc/commit/29a4132b7cb6b6a71eb1c48e3d58e4f7cc24bf89, but the release hasn't been put up yet. Sorry for the trouble