PikaMug / Quests

Easy-to-use, open-source plugin for the creation and execution of quests on Minecraft servers.
https://modrinth.com/plugin/quests.classic
MIT License
153 stars 109 forks source link

That player cannot be found #2036

Closed MisterLolxd2 closed 1 year ago

MisterLolxd2 commented 1 year ago

What is your Quests version / build number (do not say "latest")?

Quests version 4.6.1-b373

Describe the problem and how to replicate it.

This error does not appear for all Quests. However, if it appears, it is at the time of starting / finishing / leaving the quest and when checking the progress of the quest. where then this progress simply does not appear. This is what happens after upgrading to 4.6.1-b373

https://github.com/PikaMug/Quests/issues/2033

Any console errors to share?

[14:41:48 INFO]: That player cannot be found

If applicable, can you provide an example quest from quests.yml?

If player starts quests like this: https://pastebin.com/Uqvta36N the "That player cannot be found" doesn't send, but if player starts this quest: https://pastebin.com/JGhrd4zq the message sends.

FULL quest.yml: https://pastebin.com/HyegFu40
PikaMug commented 1 year ago

Thanks for the report. I was able to replicate this on a 1.8 server only; newer versions of Minecraft do not appear to be affected. At a glance, I can't tell whether this is an issue with the implementation at https://github.com/PikaMug/Quests/blob/main/v1_8_R3/src/main/java/me/blackvein/quests/nms/TitleProvider_v1_8_R3.java or a bug with Minecraft/Bukkit/Spigot/Paper.

You might be able to alleviate this by setting show-titles: false in config.yml, but titles will no longer appear in-game.

MisterLolxd2 commented 1 year ago

I'm turn show-titles to false, but "That player cannot be found" still sends.

MisterLolxd2 commented 1 year ago

The issue persists. The message sends in quests: mining, delivery, eat, but in pvp (kill players) not. In addition, the progress of tasks is not shown (mining, delivery).

PikaMug commented 1 year ago

Resolved in e7a6456

Try https://ci.codemc.io/job/PikaMug/job/Quests/395/