search

PikaMug / Quests

Easy-to-use, open-source plugin for the creation and execution of quests on Minecraft servers.
https://modrinth.com/plugin/quests.classic
MIT License
153 stars 109 forks source link

Quest Actions - Revised #2045

Closed JeremyMilam1 closed 1 year ago

JeremyMilam1 commented 1 year ago

What is your Quests version / build number (do not say "latest")?

4.6.1 with "Paper version git-Paper-307 (MC: 1.19.2) (Implementing API version 1.19.2-R0.1-SNAPSHOT) (Git: 476ef25) You are running the latest version"

Describe the problem and how to replicate it.

The quests.actions. permission does not appear to work with the above versions. I gave a user quests.actions. as well as each individual permission node associated with "actions" without success. It is met with the standard "No permission" message. When the user is given OP, it works without issue, which indicates (at least to me) that it is something on the end of the permission node. I additionally checked the discord and attempted to give quests.actions permission node without success. I additionally tried with quests.* without success.

Any console errors to share?

Not applicable, as it is a permissions issue.

If applicable, can you provide an example quest from quests.yml?

It does not call on a specific quest as it is a permissions issue.
PikaMug commented 1 year ago

Thanks for the report. What are you using for permissions? LuckPerms?

JeremyMilam1 commented 1 year ago

I am using GroupManager for permissions.

On Dec 15, 2022, at 11:05 PM, PikaMug @.***> wrote:

 Thanks for the report. What are you using for permissions? LuckPerms?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

JeremyMilam1 commented 1 year ago

Update: Attempted with legacy permissions as well, and no success.

PikaMug commented 1 year ago

I had no issues with this permission node through LuckPerms or GroupManager. The commands used were:

GroupManager /manuaddp <player> quests.actions.*

LuckPerms /lp user <player> permission set quests.actions.*

Make sure you have spelled the permission node correctly and that there are no conflicting negative permissions.

JeremyMilam1 commented 1 year ago

I just, to confirm, copy and pasted the command that you provided and it still does not work. It states the user already has access to that permission node.

On Dec 18, 2022, at 1:44 AM, PikaMug @.***> wrote:

 I had no issues with this permission node through LuckPerms or GroupManager. The commands used were:

GroupManager /manuaddp quests.actions.*

LuckPerms /lp user permission set quests.actions.*

Make sure you have spelled the permission node correctly and that there are no conflicting negative permissions.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

PikaMug commented 1 year ago

What is the "no permission" message that you get? Can you please share it verbatim.

JeremyMilam1 commented 1 year ago

The user can open up the actions list (options 1-4) but upon typing any of the numbers receives "You do not have permission to do that." in response.

PikaMug commented 1 year ago

Here's the code where you're getting stuck: https://github.com/PikaMug/Quests/blob/df2716074fc9ea9f6d3621934147dfbae7af0fbc/core/src/main/java/me/blackvein/quests/commands/quests/subcommands/QuestsActionsCommand.java#L60-L74 Note that "noPermission" is the string you're getting. As you can see, the command will work as long as your permission handler claims that the player has one of those permissions (which OPs have by default). So perhaps the next course of action is to backup your permissions database and start fresh.

JeremyMilam1 commented 1 year ago

I converted our GM over to Luckperms and it now works. Thank you.