search

PikaMug / Quests

Easy-to-use, open-source plugin for the creation and execution of quests on Minecraft servers.
https://modrinth.com/plugin/quests.classic
MIT License
141 stars 104 forks source link

Added support for ZNPCsPlus 2.X #2161

Closed D3v1s0m closed 7 months ago

PikaMug commented 7 months ago

Hi @D3v1s0m thanks for the PR. Is their API not accessible from the plugin object? I'm a little confused as to why we need a separate getZnpcsPlusApi method.

Edit: Is this to support both old and new ZNPCsPlus?

D3v1s0m commented 7 months ago

Hi @D3v1s0m thanks for the PR. Is their API not accessible from the plugin object? I'm a little confused as to why we need a separate getZnpcsPlusApi method.

A separate method is needed because all the get dependency methods returns either the plugin class or the API and in version 2.0.0 and higher of ZNPCsPlus, you will have to use the API instead of the Plugin class.

Edit: Is this to support both old and new ZNPCsPlus?

Yes, there is support for Legacy (1.0.8 and lower) as well as Latest (2.0.0 SNAPSHOTS. They are stable)