search

PikaTimer / pikatimer

PikaTimer: An OpenSource race timing application
GNU General Public License v3.0
37 stars 16 forks source link

Overall (Responsive HTML) result does not have any data #31

Closed anca-racehub closed 5 years ago

anca-racehub commented 5 years ago

After processing a result of Overall (Responsive HTML) the file contains no results.

Below is a screenshot with all options. screenshot_11

The HTML file has a header but no data. screenshot_12

Changing to Overall CSV or text works fine

segfaultcoredump commented 5 years ago

The "Loading..." tells me that the system had an issue parsing the embedded json output. This text is removed once the system has loaded the results.

See https://pikespeakmarathon.org/results/ppm/2018/ for an example of the behavior.

If you don't mind, can you attach either the resulting html file or provide a link to the file so I can view it in an attempt to determine what caused the issue?

Thanks,

--john

anca-racehub commented 5 years ago

I have attached the file (please rename it .html)

2349-responsive.log it seems there is a JS error in console.

Let me know if you need anything else.

segfaultcoredump commented 5 years ago

Thanks for the sample file, it pointed me to the error.

The custom attribute name was being used as an identifier, and you can't have spaces or other reserved items in identifiers. So I escape the text to produce something that is safe for use as an identifier.

The change can be viewed at https://github.com/segfaultcoredump/pikatimer/commit/f1435fb3ce9dfd8474927b2feaae7f1beebed5fb

segfaultcoredump commented 5 years ago

Take a look at the 1.5.2 release at https://github.com/PikaTimer/pikatimer/releases/tag/v1.5.2 to see if it fixes the issue.

anca-racehub commented 5 years ago

It works now. Thanks