PikaTimer / pikatimer

PikaTimer: An OpenSource race timing application
GNU General Public License v3.0
37 stars 16 forks source link

Result Overall (JSON) improvment for custom awards #33

Closed anca-racehub closed 5 years ago

anca-racehub commented 5 years ago

It would be very useful (for those that are automatically processing results with a script) to have the JSON response improved for custom awards

Example:

Configuration screenshot

screenshot_15 Result { "bib": "34", "age": "30", "sex": "F", "ag": "0+", "full_name": "stela cotonea", "full_name_filter": "stela cotonea", "first_name": "stela", "middle_name": "", "last_name": "cotonea", "city": "", "state": "", "country": "", "note": "", "custom_Age group": "Feminin 19-35 ani", "award_winner": "yes", "awards": { "award_0": "1st Overall — Female (Time: 1:01:21)", "award_1": "1st ClasamentCategorii — StringProperty [value: Feminin 19-35 ani] (Time: 1:01:21)" }, "oa_place": "1", "sex_place": "1", "ag_place": "1", "last_seen": "Never", "start_display": "16:00:00", "finish_display": "1:01:21", "finish_sort": "1:01:21", "finish_pace": "6:08/km" },

Desired behavior:

the awards object could have the fields split like below:

"awards": { "award_0": { "title": "1st Overall Female (Time: 1:01:21)", "place":"1", "time":"1:01:21" }, "award_1": { "title": "1st ClasamentCategorii - Feminin 19-35 ani (Time: 1:01:21)", "place":"1", "time":"1:01:21" } }, This way it could be easily parsed by a script.

segfaultcoredump commented 5 years ago

I don't want to break the existing use of the awards array, so how about something like this?

        "award_winner": "yes",
        "awards": {
            "award_0": "1st Overall - Male (Time: 3:32:20)"
        },
        "award_Detail": {
            "award_Overall": {
                "title": "Overall",
                "category": "Male",
                "place": "1",
                "time": "3:32:20",
            }
        }
anca-racehub commented 5 years ago

That's perfect. When are you planning the next release? or beta version?

segfaultcoredump commented 5 years ago

Take a look at the 1.5.2 release at https://github.com/PikaTimer/pikatimer/releases/tag/v1.5.2 to see if it fixes the issue.

anca-racehub commented 5 years ago

Thanks for the fix, it works now.