search

PikaTimer / pikatimer

PikaTimer: An OpenSource race timing application
GNU General Public License v3.0
37 stars 16 forks source link

Results won't publish because i didn't select race in awards section #39

Open Ymil opened 2 years ago

Ymil commented 2 years ago

Hello.

I found that when I try to get the race results, the software does not post the result and does not display an error message. It just won't get published.

With a small debug in the code, I detected that it is because I did not select the race in the awards section, that is when the awards are configured in the race, I understand.

This problem only exists if you just test the software and don't really use it, this is my case hehe.

Workaround: When you first set up a race, you need to click on the prize section and select the different races, and then you can report correctly.

Ymil commented 2 years ago

Add the commit for show where is the problem.

segfaultcoredump commented 2 years ago

Thanks for spotting this.

I have a v1.6 branch off to the side that I've been working on for two years and hope to have out this summer.

I'll have to look at the code to determine if it is better to fix it when a race is first created (probably better) or when the report is run. I'm leaning toward both: The default awards should be there and not be created upon first viewing of the tab and the reports should have better error checking.

Ymil commented 2 years ago

Hi, thanks to you for the great software!

I agree with you, i think it's better created the default awards when create the race.

But for now maybe is possible and easier add "Frecuency Problems" section in the readme?

And if you are agree, i add this with a little notes for development enviroment section that i taked when made the enviroment.