PikeNote / taskbar-groups-pike-beta

Lightweight application that lets users create and pin groups to the Windows taskbar och desktop
MIT License
126 stars 9 forks source link

Unhandled Exception - Looking for Shortcut's Target File in Wrong Folder #19

Closed WisdomCritFail closed 1 year ago

WisdomCritFail commented 2 years ago

I have a shortcut that opens "C:\Program Files\Oracle\VirtualBox\VirtualBox.exe". For some reason, when I try to add this shortcut to a group, it gives me an error saying that "C:\Program Files (x86)\Oracle\VirtualBox\VirtualBox.exe" doesn't exist.

The path in my shortcut goes through the "Program Files" folder so idk why it's even looking in "Program Files (x86)".

image

Error message ----

See the end of this message for details on invoking just-in-time (JIT) debugging instead of this dialog box.

** Exception Text ** System.IO.FileNotFoundException: C:\Program Files (x86)\Oracle\VirtualBox\VirtualBox.exe at System.Drawing.Icon.ExtractAssociatedIcon(String filePath, Int32 index) at client.Forms.frmGroup.handleLnkExt(String file) in C:\Users\jacks\Desktop\Taskbar dev\main\main\Forms\frmGroup.cs:line 390 at client.User_controls.ucProgramShortcut.ucProgramShortcut_Load(Object sender, EventArgs e) in C:\Users\jacks\Desktop\Taskbar dev\main\main\User controls\ucProgramShortcut.cs:line 64 at System.Windows.Forms.UserControl.OnLoad(EventArgs e) at System.Windows.Forms.UserControl.OnCreateControl() at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible) at System.Windows.Forms.Control.CreateControl() at System.Windows.Forms.Control.ControlCollection.Add(Control value) at client.Forms.frmGroup.LoadShortcut(ProgramShortcut psc, Int32 position) in C:\Users\jacks\Desktop\Taskbar dev\main\main\Forms\frmGroup.cs:line 127 at client.Forms.frmGroup.addShortcut(String file, Boolean isExtension) in C:\Users\jacks\Desktop\Taskbar dev\main\main\Forms\frmGroup.cs:line 225 at client.Forms.frmGroup.pnlAddShortcut_Click(Object sender, EventArgs e) in C:\Users\jacks\Desktop\Taskbar dev\main\main\Forms\frmGroup.cs:line 174 at System.Windows.Forms.Control.OnClick(EventArgs e) at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) at System.Windows.Forms.Control.WndProc(Message& m) at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m) at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m) at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

** Loaded Assemblies ** mscorlib Assembly Version: 4.0.0.0 Win32 Version: 4.8.4470.0 built by: NET48REL1LAST_C CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll

TaskbarGroups Assembly Version: 0.2.0.0 Win32 Version: 0.2.0.0 CodeBase: file:///C:/Users/mattb/AppData/Roaming/Microsoft/Windows/Start%20Menu/TaskbarGroups/TaskbarGroups.exe

System.Drawing Assembly Version: 4.0.0.0 Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll

System Assembly Version: 4.0.0.0 Win32 Version: 4.8.4360.0 built by: NET48REL1LAST_C CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll

System.Windows.Forms Assembly Version: 4.0.0.0 Win32 Version: 4.8.4400.0 built by: NET48REL1LAST_C CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll

System.Configuration Assembly Version: 4.0.0.0 Win32 Version: 4.8.4190.0 built by: NET48REL1LAST_B CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll

System.Core Assembly Version: 4.0.0.0 Win32 Version: 4.8.4470.0 built by: NET48REL1LAST_C CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll

System.Xml Assembly Version: 4.0.0.0 Win32 Version: 4.8.4084.0 built by: NET48REL1 CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

Microsoft.GeneratedCode Assembly Version: 1.0.0.0 Win32 Version: 4.8.4084.0 built by: NET48REL1 CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

System.Net.Http Assembly Version: 4.0.0.0 Win32 Version: 4.8.4084.0 built by: NET48REL1 CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Net.Http/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Net.Http.dll

Windows.Data Assembly Version: 255.255.255.255 Win32 Version: 10.0.10011.16384 CodeBase: file:///C:/Windows/SysNative/WinMetadata/Windows.Data.winmd

System.Runtime Assembly Version: 4.0.0.0 Win32 Version: 4.8.4084.0 CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Runtime/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Runtime.dll

Windows.Foundation Assembly Version: 255.255.255.255 Win32 Version: 10.0.10011.16384 CodeBase: file:///C:/Windows/SysNative/WinMetadata/Windows.Foundation.winmd

Accessibility Assembly Version: 4.0.0.0 Win32 Version: 4.8.4084.0 built by: NET48REL1 CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll

Microsoft.CSharp Assembly Version: 4.0.0.0 Win32 Version: 4.8.4084.0 CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Microsoft.CSharp/v4.0_4.0.0.0__b03f5f7f11d50a3a/Microsoft.CSharp.dll

System.Dynamic Assembly Version: 4.0.0.0 Win32 Version: 4.8.4084.0 CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Dynamic/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Dynamic.dll

Anonymously Hosted DynamicMethods Assembly Assembly Version: 0.0.0.0 Win32 Version: 4.8.4470.0 built by: NET48REL1LAST_C CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_32/mscorlib/v4.0_4.0.0.0__b77a5c561934e089/mscorlib.dll

Windows.Management Assembly Version: 255.255.255.255 Win32 Version: 10.0.10011.16384 CodeBase: file:///C:/Windows/SysNative/WinMetadata/Windows.Management.winmd

Windows.ApplicationModel Assembly Version: 255.255.255.255 Win32 Version: 10.0.10011.16384 CodeBase: file:///C:/Windows/SysNative/WinMetadata/Windows.ApplicationModel.winmd

System.Runtime.WindowsRuntime Assembly Version: 4.0.0.0 Win32 Version: 4.8.4084.0 built by: NET48REL1 CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Runtime.WindowsRuntime/v4.0_4.0.0.0__b77a5c561934e089/System.Runtime.WindowsRuntime.dll

Windows.Storage Assembly Version: 255.255.255.255 Win32 Version: 10.0.10011.16384 CodeBase: file:///C:/Windows/SysNative/WinMetadata/Windows.Storage.winmd

** JIT Debugging ** To enable just-in-time (JIT) debugging, the .config file for this application or computer (machine.config) must have the jitDebugging value set in the system.windows.forms section. The application must also be compiled with debugging enabled.

For example:

When JIT debugging is enabled, any unhandled exception will be sent to the JIT debugger registered on the computer rather than be handled by this dialog box.

JohnLGalt commented 2 years ago

Add it manually, is what I've always had to do.

PikeNote commented 1 year ago

That is odd. I should've fixed this. I can't seem to reproduce it at the moment. @JohnLGalt, if possible, can you give steps for an exact replication of the issue? I have tried WinRar which has the path C:\Program Files\WinRAR\WinRAR.exe as a shortcut, and it seems to open it just fine.

JohnLGalt commented 1 year ago

Sure thing.

  1. Create a group.
  2. Add shortcuts.
  3. Close TBG executable. Doesn't even need to have group shortcut on taskbar.
  4. Go to folder with shortcuts, and remove any one.
  5. Open TBG executable and it complains incessantly with that error.

Once you edit the group and remove the missing shortcut(s) it is fine again. But as long as the settings (.XML?) contains a reference to a shortcut that it cannot find, it manifests that error.

PikeNote commented 1 year ago

Hmm, that is odd. Have you built the latest yet?

Here are my steps

  1. Create a group
  2. Add shortcuts to the group I used .lnk files to WinRar and WinSCP (WinRar is in ProgramFiles and WinSCP is in Program FIles x86) placed on the Desktop
  3. Close the main executable for making groups (also tried closing the background)
  4. Go to folder with the shortcut generated and delete that (I also tried deleting the shortcuts I have linked)

I haven't been able to produce the exact error that is happening there.

JohnLGalt commented 1 year ago

I'm still using last year's Alpha lol - have not tried building anything newer. So, in my case, at least, that is definitely a contributing factor.

PikeNote commented 1 year ago

@JohnLGalt Taskbar Groups.zip Try this build

JohnLGalt commented 1 year ago

I'll also look at the dev instructions to set up a build env here locally so I can start keeping up with updates.

But thanks for the build this go around - I'm hoping this fixes the minor issues I have with missing / deleted shortcuts and uninstalled apps.

I'll test over the next couple of days and report back.

JohnLGalt commented 1 year ago

@PikeNote Using your newly compiled executable, when trying to add a program a new group, using the default folder that the executable opens to find shortcuts, I'm getting the following:

Unhandled exception has occurred in your application. If you click Continue, the application will ignore this error and attempt to continue. If you click Quit, the application will close immediately.

Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.UnauthorizedAccessException: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))
   at Shell32.FolderItem.get_GetLink()
   at client.Forms.frmGroup.handleLnkExt(String file)
   at client.User_controls.ucProgramShortcut.ucProgramShortcut_Load(Object sender, EventArgs e)
   at System.Windows.Forms.UserControl.OnLoad(EventArgs e)
   at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
   at System.Windows.Forms.Control.CreateControl()
   at System.Windows.Forms.Control.ControlCollection.Add(Control value)
   at client.Forms.frmGroup.LoadShortcut(ProgramShortcut psc, Int32 position)
   at client.Forms.frmGroup.pnlAddShortcut_Click(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

************** Loaded Assemblies **************
mscorlib
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9105.0 built by: NET481REL1LAST_C
    CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll
----------------------------------------
Taskbar Groups
    Assembly Version: 0.2.2.0
    Win32 Version: 0.2.2.0
    CodeBase: file:///E:/Programs/TaskBarGroupsAlpha%20by%20Pike/Taskbar%20Groups.exe
----------------------------------------
System.Windows.Forms
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9075.0 built by: NET481REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9065.0 built by: NET481REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9032.0 built by: NET481REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
System.Core
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9105.0 built by: NET481REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------
System.Xml
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9032.0 built by: NET481REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Configuration
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9032.0 built by: NET481REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.8.9032.0 built by: NET481REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.CSharp
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9032.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Microsoft.CSharp/v4.0_4.0.0.0__b03f5f7f11d50a3a/Microsoft.CSharp.dll
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.8.9032.0 built by: NET481REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Net.Http
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9032.0 built by: NET481REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Net.Http/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Net.Http.dll
----------------------------------------
Windows.Data
    Assembly Version: 255.255.255.255
    Win32 Version: 10.0.10011.16384
    CodeBase: file:///C:/WINDOWS/system32/WinMetadata/Windows.Data.winmd
----------------------------------------
System.Runtime
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9032.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Runtime/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Runtime.dll
----------------------------------------
Windows.Foundation
    Assembly Version: 255.255.255.255
    Win32 Version: 10.0.10011.16384
    CodeBase: file:///C:/WINDOWS/system32/WinMetadata/Windows.Foundation.winmd
----------------------------------------
Accessibility
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9032.0 built by: NET481REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------
System.Dynamic
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.9032.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Dynamic/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Dynamic.dll
----------------------------------------
Anonymously Hosted DynamicMethods Assembly
    Assembly Version: 0.0.0.0
    Win32 Version: 4.8.9105.0 built by: NET481REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_64/mscorlib/v4.0_4.0.0.0__b77a5c561934e089/mscorlib.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Trying to set up a group for browsers. I Have Firefox Nightly, Firefox, Chrome and Edge. Adding Firefox, Firefox Nightly and Chrome from C:\ProgramData\Microsoft\Windows\Start Menu\Programs Causes the above every time.

This is after converting my install to portable mode.

JohnLGalt commented 1 year ago

I can point to the executable directly, and it works, though for some reason it is using a single icon for both Firefox Nightly and Firefox (stable). Previous executable (Alpha from July 2021) did not have this issue, Nightly icon was different from Firefox stable icon.

I figured it out - and probably have figured it out in the past as well.

If I link directly to the executable, both apps are named firefox.exe, so whichever one is second will have the exact same image name as the first and its image replaces the other.

Linking to a shortcut that I made of both apps in another location works perfectly fine, each keeps it's distinct icon, because one shortcut is named Nightly and the other is named Firefox.

And the previous post is probably the same thing you mentioned before, about protected spaces. I suspect that C:\ProgramData is actually (at least partially) protected in some manner, so linking to any shortcuts in that default path that opens up causes the exception.

Now, the only thing I am left having a problem with is that, in the past, I had no issues making shortcuts (on the desktop) of apps installed from the Microsoft store and using them to add to TBG groups. This latest version does not seem to like that at all. I'm going to test further - after making those shortcuts I moved them to the same location as the Firefox and Nightly shortcuts, and that might be the factor, I'll try leaving them on the desktop and see if that works.

Otherwise, what is the best way to add Microsoft Store apps to TBG groups?

PikeNote commented 1 year ago

Thanks for getting back so quickly. Here is what I found. The error you encountered is from the new folder links code I put in to fix the special character issue. According to this post, it doesn't work well with protected spaces. I will most likely have to ask for administrator access if that happens. Will fix that asap.

I'll do some testing on my end as well with the issues you've encountered. That is an interesting issue cause even though firefox.exe for say nightly is the same name, it has a different exe icon. I think this is related to the icon caching system not recognizing the difference. Will add a fix for that by changing the naming scheme (need to find a safe way to do that without breaking all current groups).

Lastly, I will do some testing with Microsoft Store apps. It is odd that it broke that way. Will get back to you with alternative methods as soon as I find them or a fix.

Edit: The other way that was used to add Microsoft Store apps was to directly drag it from Windows start menu to the taskbar (used drag and drop feature). That was what I tested. I do get issues trying to do the shortcut, most likely need to add a check for the weird target file paths the shortcuts used.

PikeNote commented 1 year ago

Actually thinking about it, the old Shell32 method which is used to read the .lnk files does not have the configurability to disable the permission of "EnableChangingProperties" as mentioned in the post. That means anything using it will most likely require read/write permissions, and that may relate to #21. I wonder if there is a way to modify Shell32 to not do that or override the method. I'll look into it.

PikeNote commented 1 year ago

Taskbar Groups.zip @JohnLGalt Fixes done for everything you mentioned (I think).

JohnLGalt commented 1 year ago

Thank you! I'll get to testing with this new version today.

JohnLGalt commented 1 year ago

I've tested it - it is accepting some (most) shortcuts created from shell:AppsFolder, but not all. I'll put a list together for the ones that still don't work.

Also, the shortcuts made from shell:AppsFolder are created by right clicking on a desired app and selecting Create Shortcut, which then prompts the user that the shortcut cannot be created in the current location and asks to create it on the Desktop instead.

Finally, I'm also copying the shortcuts from the desktop to a folder that I created in the folder with the TBG executables, called My Shortcuts (on a third drive, E: - so full path is E:\Programs\TaskBarGroupsAlpha by Pike\My Shortcuts\{name of group to be used in} - so I don't think there should be a permission problem at all. I don't think Desktop should have a permission problem either, but just in case, since it is in the \Users folder, I copied them to their own folders on E:.

And, finally, I am using portable mode, so all of this stuff (executables, settings, configs, and the folders I made to store the shortcuts) is in E:\Programs\TaskBarGroupsAlpha by Pike\, if that makes any difference.

PikeNote commented 1 year ago

After just a while of testing and messing around, Windows shortcuts are a mess to deal with in the shell:AppsFolder. Targets for certain ones don't have consistent naming schemes, some just don't reference a direct ico. What I just decided to do was shotgun together a bunch of methods and hopefully at least one of them gets it.

If not, it will just take the shortcut icon with the arrow and being low quality. Best solution I can think of as of now.

Taskbar Groups.zip Has the patch for Hi-DPI so if you would like to test that alongside the shotgun fixes.

JohnLGalt commented 1 year ago

Oooh, sweet.

A lot from shell:AppsFolder that did not work had a shortcut reference that starts with an open brace "{". Native Microsoft apps are now working perfectly fine as shortcuts from shell:AppsFolder except Windows Explorer lol.

I've been collecting them into a single folder, and .ZIPped them up, so you can take a look at them, see attachment.

Shortcuts.zip

I realize that these shortcuts won't help a lot as they are not actually installed on your system, but they might help clue in why some are failing. Apps the have a reference with an opening "{" character, and a couple of others, are in the archive.

In the mean time I'll try the new build.

JohnLGalt commented 1 year ago

Uh, the one previous to the one above did not also copy in the shortcut overlay on the icons, but this one does.

Latest version from https://github.com/PikeNote/taskbar-groups-pike-beta/issues/19#issuecomment-1352454841

Screenshot 2022-12-14 215603

Older version from https://github.com/PikeNote/taskbar-groups-pike-beta/issues/19#issuecomment-1351116783

Screenshot 2022-12-14 215615

SxS comparison from TBG app:

Screenshot 2022-12-14 215642
PikeNote commented 1 year ago

Taskbar Groups.zip Made some quick fixes. I tested it with my Steam, so it hopefully shouldn't do that anymore. Rolled back some old changes since I have trouble killing the background process gracefully (caused the groups to be outdated until the background is restarted).

JohnLGalt commented 1 year ago

Actually, that was another issue I was going to ask about - does that background task need to be always running?

I'll grab the latest and test today or tomorrow.

JohnLGalt commented 1 year ago

I used the one from https://github.com/PikeNote/taskbar-groups-pike-beta/issues/19#issuecomment-1352513322 - doesn't seem to carry the overlays, and when editing a group, the already pinned TBG updated without having to remove and add it back, even with the background app closed.

Also, the item I added was a new MSIX bundled app manually installed on my system, so that also worked in this case.

I'll test some more and report back if I have any issues.

JohnLGalt commented 1 year ago

A manually installed MSIX AppBundle, specifically MusicBrainz Picard, downlaoded from their GitHub repository, can only be added if I first make a shortcut on the desktop to it. But, the current TBG from #19 still brought over the Shortcut overlay.

Screenshot 2022-12-22 114946
JohnLGalt commented 1 year ago

I've formatted and cleanly installed Windows 11 due to some unforeseen issues, and since I was using TBG in portable mode, all my groups stayed in place. Once I get the majority of apps reinstalled, I'll test the old groups with freshly made groups and see if anything is amiss.

JohnLGalt commented 1 year ago

Clean Windows install, and thus far everything seems to be installing correctly. I have 7 unique groups on my taskbar, comprising of both manually installed programs (Program files and PFx86) as well as UWP apps (both installed from the Microsoft Store as well as sideloaded).

Every one is being accepted into its group (using shortcuts for UWPs from shell:AppsFolder) and none of the icons are carrying over the shortcut overlay for any of those shortcuts.

I've also have 0 unhandled exceptions since using the build from #19.

@PikeNote - great job. If you need anything else from me let me know I still plan to add several more group icons to my desktop.

PikeNote commented 1 year ago

@JohnLGalt Thanks! Since it seems like this is mostly all resolved, I will close this issue for now (also no response from original author). I have found a fix for MusicBrainz (bug) and will push out the new release with #25 once I add it in. Last thing I want to fix is drag and drop from Windows 11 Start Menu (Windows 10 works).