PikeNote / taskbar-groups-pike-beta

Lightweight application that lets users create and pin groups to the Windows taskbar och desktop
MIT License
126 stars 9 forks source link

Shortcut can't be added (access denied) #43

Closed BanCrash closed 1 year ago

BanCrash commented 1 year ago

Hi, I've tried to add the shortcut for ScreenToGif (installed version) but I got this error:

imagen

It says that access denied. I thought it could be because the main executable is placed on Program files folder, but there are other shortcuts that have their main executable on that folder and doesn't give any error...

Error message:

`Consulte el final de este mensaje para obtener más detalles sobre cómo invocar a la depuración Just-In-Time (JIT) en lugar de a este cuadro de diálogo.

** Texto de la excepción ** System.UnauthorizedAccessException: Acceso denegado. (Excepción de HRESULT: 0x80070005 (E_ACCESSDENIED)) en Shell32.FolderItem.get_GetLink() en client.Classes.handleWindowsApp.GetLnkTarget(String lnkPath) en client.Classes.handleWindowsApp.getWindowsAppIcon(String file, Boolean alreadyAppID) en client.Forms.frmGroup.handleLnkExt(String file) en client.User_controls.ucProgramShortcut.ucProgramShortcut_Load(Object sender, EventArgs e) en System.Windows.Forms.UserControl.OnLoad(EventArgs e) en System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible) en System.Windows.Forms.Control.CreateControl() en System.Windows.Forms.Control.ControlCollection.Add(Control value) en client.Forms.frmGroup.LoadShortcut(ProgramShortcut psc, Int32 position) en client.Forms.frmGroup.pnlAddShortcut_Click(Object sender, EventArgs e) en System.Windows.Forms.Control.OnClick(EventArgs e) en System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) en System.Windows.Forms.Control.WndProc(Message& m) en System.Windows.Forms.Label.WndProc(Message& m) en System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

** Ensamblados cargados ** mscorlib Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4515.0 built by: NET48REL1LAST_C Código base: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll

Taskbar Groups Versión del ensamblado: 0.2.2.0 Versión Win32: 0.2.2.0 Código base: file:///D:/Programas/Taskbar%20Groups/Taskbar%20Groups.exe

System.Windows.Forms Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4550.0 built by: NET48REL1LAST_C Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll

System Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4605.0 built by: NET48REL1LAST_C Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll

System.Drawing Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4390.0 built by: NET48REL1LAST_C Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll

System.Core Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4605.0 built by: NET48REL1LAST_C Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll

System.Xml Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4084.0 built by: NET48REL1 Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

System.Configuration Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4190.0 built by: NET48REL1LAST_B Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll

mscorlib.resources Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4084.0 built by: NET48REL1 Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/mscorlib.resources/v4.0_4.0.0.0_es_b77a5c561934e089/mscorlib.resources.dll

Microsoft.GeneratedCode Versión del ensamblado: 1.0.0.0 Versión Win32: 4.8.4084.0 built by: NET48REL1 Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

Microsoft.CSharp Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4084.0 Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Microsoft.CSharp/v4.0_4.0.0.0__b03f5f7f11d50a3a/Microsoft.CSharp.dll

System.Dynamic Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4084.0 Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Dynamic/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Dynamic.dll

Anonymously Hosted DynamicMethods Assembly Versión del ensamblado: 0.0.0.0 Versión Win32: 4.8.4515.0 built by: NET48REL1LAST_C Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_64/mscorlib/v4.0_4.0.0.0__b77a5c561934e089/mscorlib.dll

Kaitai.Struct.Runtime Versión del ensamblado: 0.10.0.0 Versión Win32: 0.2.2.0 Código base: file:///D:/Programas/Taskbar%20Groups/Taskbar%20Groups.exe

System.Net.Http Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4084.0 built by: NET48REL1 Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Net.Http/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Net.Http.dll

Microsoft.GeneratedCode Versión del ensamblado: 1.0.0.0 Versión Win32: 4.8.4084.0 built by: NET48REL1 Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

Windows.Data Versión del ensamblado: 255.255.255.255 Versión Win32: 10.0.10011.16384 Código base: file:///C:/WINDOWS/system32/WinMetadata/Windows.Data.winmd

Windows.Foundation Versión del ensamblado: 255.255.255.255 Versión Win32: 10.0.10011.16384 Código base: file:///C:/WINDOWS/system32/WinMetadata/Windows.Foundation.winmd

System.Windows.Forms.resources Versión del ensamblado: 4.0.0.0 Versión Win32: 4.8.4084.0 built by: NET48REL1 Código base: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms.resources/v4.0_4.0.0.0_es_b77a5c561934e089/System.Windows.Forms.resources.dll

** Depuración JIT ** Para habilitar la depuración Just In Time (JIT), el archivo de configuración de esta aplicación o equipo (machine.config) debe tener el valor jitDebugging establecido en la sección system.windows.forms. La aplicación también se debe compilar con la depuración habilitada

Por ejemplo:

Cuando esté habilitada la depuración JIT, cualquier excepción no controlada se enviará al depurador JIT registrado en el equipo en lugar de controlarlo mediante el cuadro de diálogo. `

PikeNote commented 1 year ago

I just found a duplicate code area found and fixed in https://github.com/PikeNote/taskbar-groups-pike-beta/commit/0fb81ee74e2862b88e5a71ec98f2f433a9371872 that should stop it from crashing.

The default behavior for errors should just be trying to extract the icon directly (with the shortcut arrow if it is a shortcut) so a crash like that shouldn't have happened.

But besides that, can you give me the program shortcut that was used in this case? Seems like there is an error with it, as when I installed (x64 version) on my system, I didn't have an issue adding it (both the shortcut + main exe). The shortcut was located in Windows -> Start Menu and the main exe was located in Program Files.

BanCrash commented 1 year ago

I just found a duplicate code area found and fixed in 0fb81ee that should stop it from crashing.

The default behavior for errors should just be trying to extract the icon directly (with the shortcut arrow if it is a shortcut) so a crash like that shouldn't have happened.

But besides that, can you give me the program shortcut that was used in this case? Seems like there is an error with it, as when I installed (x64 version) on my system, I didn't have an issue adding it (both the shortcut + main exe). The shortcut was located in Windows -> Start Menu and the main exe was located in Program Files.

I will compile that version and test if it fixes this issue, but here it is the shortcut: ScreenToGif.zip

This is the properties of the shortcut sent: imagen

BanCrash commented 1 year ago

With the last commit this is not happening anymore, so it seems that was the issue, thanks!