PikeNote / taskbar-groups-pike-beta

Lightweight application that lets users create and pin groups to the Windows taskbar och desktop
MIT License
126 stars 9 forks source link

TBG 0.2.2.1 created group shows different icon than on taskbar #48

Open JohnLGalt opened 1 year ago

JohnLGalt commented 1 year ago

Hi, @PikeNote

I just ran into this, and I'm not sure how long it has been happening, as I've not had to change my groups in quite a while.

One of my programs recently had an update where the icon had changed, but the group with that program in it still used old icon. I tried removing the program from the group, then adding it back in and the new icon shows, but the group icon is still using the old one.

I then deleted the group entirely, and created a new group, but instead of adding the first four items in the group as a group icon in order, it reversed the order. I then deleted that group and created a new group, added the first four items in the group in reverse order, and the group icon is now as I want it.

However, when pinning it to the taskbar, it still shows the reverse order.

Here are some screenshots to illustrate.

Screenshot 2023-03-22 135449

Group as created in TBG 0.2.2.1

Screenshot 2023-03-22 135646

Output icon of group that gets pinned to the tb

I also tried to clear all pinned items on the taskbar, in case it was a left over icon, and rebooted, but it is definitely the app creating an icon out of the added apps that is reverse if what it normally does.

I'll try creating the same group with the old 0.2.2.0 release next.

Another issue here is that sometimes (and randomly) the shortcut overlay icon is not being stripped. I have all the shortcuts to the apps in this group in a single location, some are from installed programs in \Program Files / \Programs Files (X86) and some from portable programs with extracted .ZIP files in a \Programs folder on a separate drive - and it's completely random in removing the overlay, with some from each group. Note that this group does not use any Microsoft Store apps, only manually installed and manually extracted apps.

Windows 11 Pro 22H2 build 22621.1413 TBG 0.2.2.1 (SHA256: 4448125b4d2e6778fcaf4c0af4cda7d7daec806d4ea9f43bd6ae4b23eaffc3cd)

I think this version is one of the ones you posted as a fix to someone else's problem in one of the issues, but I'm not 100% sure which one it is...

JohnLGalt commented 1 year ago

I just tried with 0.2.2.0. It is doing the exact same thing in terms of icon placement of the group icon.

However, it correctly removes all of the shortcut overlays. I'm flummoxed now. I don't understand why it is doing this.

JohnLGalt commented 1 year ago

Also, putting the first four items in reverse order does not solve the issue, they still appear as in the second screenshot.

Basically, it seems like TBG is saying it's going to create a group icon that looks like this, but when creating it something gets in the way and forces it to be created another way. It's not even alphabetical, as the for apps are:

  1. Files Preview
  2. Files
  3. Xplorer²
  4. OneCommander

The order I want to achieve, as seen in the first screen shot is:

  1. OneCommander
  2. Xplorer²
  3. Files Preview
  4. Files
JohnLGalt commented 1 year ago

OK, I did some more investigating. I think it is a Windows thing, but I'm not sure where the hell I'm supposed to solve it from.

If I delete the group and recreate it identically but named Storage, the icons are in the right order.

If I rename that same Storage group back to Folders, the icons reverse. And renaming it back to Storage fixes the icon order again.

IOW, something, somewhere, is caching that group icon for any group named Folders.

PikeNote commented 1 year ago

I'll look into this. Odd that 0.2.2.1 randomly removes/adds shortcut icons at random.

I suspect https://github.com/PikeNote/taskbar-groups-pike-beta/commit/4abee15793c0043608e3288d90b3bb631c195700 has to do something with this when I switched the lnk icon gathering method once again. I didn't like the added size/bulk of the other library that was used to achieve it. If it is more consistent, I am down to re-implement it but I will look for some solutions as of now.