search

PileProject / drive

The drive project
Other
5 stars 4 forks source link

Hotfix/setting bugs #51

Closed tiwanari closed 7 years ago

tiwanari commented 7 years ago

I found the port setting didn't work properly. So, I made this PR.

I think this will also close #43. I shortened the name of devices (i.e., sensors and motors) in order not to make screen collapsed. Please look at the following figure.

BTW, @myusak said the threshold sub-screen also collapsed on #38 but I couldn't see that. So, could you share a figure that illustrates it? :)

screenshot_20161023-140749

mandaiy commented 7 years ago

This was what I got in my emulator (Nexus_5X_API_24_x86) I didn't check that screen resolution do matter or not, the above was in 1080x1920, 420dpi

device-2016-10-25-203231

tiwanari commented 7 years ago

Hi @myusak, Thanks! I checked it with different resolutions & APIs and found it may be a problem related to APIs because I got it with API 23+ and didn't see with API 22 regardless of resolutions (Phone, Tablet). Anyway, I will dig into the problem :)

mandaiy commented 7 years ago

Or we can solve this by adding resizing function like this

tiwanari commented 7 years ago

Now, I'm trying to figure out the cause of the error on the threshold sub-screen. So, give me a little time.

tiwanari commented 7 years ago

Oh, I also found a difference between API 22 and 23. Note: These dialogs (sub-screens) have titles in API 22 and not in API 23.

tiwanari commented 7 years ago

Hi @myusak,

I used your suggestion and these collapsed screen has been fixed regardless of APIs :) But I'm not still sure why this happened and don't fix about the titles...

API 22: API 22 API 23: API 23

mandaiy commented 7 years ago

Maybe theme related problems? Can you specify the dialog theme of the app in some xml file for NoTItle or something?

tiwanari commented 7 years ago

I tried changing WindowNoTitle flag from false to true at here and emulators got an error when the app starts... Do you have any idea why this happens and how to solve it?

tiwanari commented 7 years ago

Hmm... It seems to be a problem related to AppCompat updates. Now my question has changed from "why don't titles appear in API 23+" to "why do titles apper in API 22" in spite of the flag windowNoTitle.

But I think this is not so critical at this point.

tiwanari commented 7 years ago

I will merge this