Introduce Dagger2 - Githubissues

PileProject / drive

The drive project

Other

5 stars 4 forks source link

Closed mandaiy closed 7 years ago

mandaiy commented 7 years ago

This PR closes #31 and #45.

Following changes are made:

Renamed Activities' name by removing suffix "Base"
Changed intent-creation strategy. An intent for an Activity is created by the Activity's static method
Added DI code for BlockProvider and MachineProvider

In addition to these changes, minor changes were made

Moved Block category constants to @BlockCategory annotation interface
Changed the way of invoking MachineBase.connect (Thread to RxJava) in ExecutionActivity
Refactored some code

tiwanari commented 7 years ago

Hi @myusak,

I haven't looked into your codes yet but I guess this PR also resolves #31 thanks to the change on how to make intents;

Changed intent-creation strategy. An intent for an Activity is created by the Activity's static method

Is my guess right?

Will you add more changes? Please let us know when you finished fixing :)

mandaiy commented 7 years ago

your understanding is correct and i won't add commits anymore unless you want

tiwanari commented 7 years ago

Thanks for your confirmation :) I will check them soon 👍

tiwanari commented 7 years ago

Hi @amiq11,

Though I approved this PR, please have a look and feel free to make comments :) If you don't have enough time, please let us know.

mandaiy commented 7 years ago

@amiq11 ping. I gonna merge this until the end of tomorrow unless you complain. Thanks.