Remove extra check for host

PillarTechnology / botkit-storage-mysql

A MySQL storage driver for Botkit

Apache License 2.0

3 stars 6 forks source link

Remove extra check for host #1

Closed PanMan closed 8 years ago

PanMan commented 8 years ago

I'm using MySQL with a ClearDB package on Heroku. The ClearDB credentials come as an URL. The MySQL package is able to handle this url directly e.g. this works:

var connection = mysql.createConnection(process.env["CLEARDB_DATABASE_URL"]);

However, this package (erroneously) checks if the host property is set. This prevents me from connecting to MySQL with an URL.

JarredOlson commented 8 years ago

Thanks for the PR! I'll get this pushed out shortly.