search

Pilloxa / react-native-nordic-dfu

Nordic Device Firmware Update for React Native
MIT License
139 stars 119 forks source link

Update iOSDFULibrary to fix compilation errors on XCode 13 #149

Closed sofiaschn closed 3 years ago

sofiaschn commented 3 years ago

iOSDFULibrary released today a new version to fix the compilation errors on XCode 13.

robwalkerco commented 3 years ago

Hi @Matheuschn, Just got your email.

Your change is essentially the same as I've been doing via patch-package for the last week or so.

My patch is 

diff --git a/node_modules/react-native-nordic-dfu/react-native-nordic-dfu.podspec b/node_modules/react-native-nordic-dfu/react-native-nordic-dfu.podspec
index 5307493..907d724 100644
--- a/node_modules/react-native-nordic-dfu/react-native-nordic-dfu.podspec
+++ b/node_modules/react-native-nordic-dfu/react-native-nordic-dfu.podspec
@@ -16,5 +16,5 @@ Pod::Spec.new do |s|
   s.source_files  = "ios/**/*.{h,m}"

   s.dependency 'React'
-  s.dependency 'iOSDFULibrary', '~> 4.7.1'
+  s.dependency 'iOSDFULibrary', '~> 4.11.0'
 end

As far as I'm concerned, your PR is good (though I've not tested the iOSDFULibrary patch version 4.11.1 yet)

Hopefully a maintainer will be able to merge and release as a new version on NPM 🤞 , otherwise we will be stuck either installing from the github PR branch, or using patch-package.

sofiaschn commented 3 years ago

Thanks for the reply @robwalkerco. I tried sending an email to some people involved in this project and to Pilloxa (looks like it is a company), in hopes that we can get some action here to merge this PR.

townofdon commented 3 years ago

@Matheuschn PR looks good - I'm also not a contributor so cannot merge the changes. As @robwalkerco pointed out above, a stopgap measure in the meantime would be to use patch-package for your project until this PR is merged and another npm version released. Looks like you may already know about this but wanted to recommend it just in case.

I've had very good luck with patch-package and it's saved my arse more than once.

yannvanhalewyn commented 3 years ago

Thanks everyone for the contribution!

yannvanhalewyn commented 3 years ago

We had a change of staff here at Pilloxa, I'm the new guy. Seems like the version published to NPM is ahead of what's in Github, which sounds like changes were published without pushing here. I'd be happy to publish a new version to include this PR, but could anyone give some insights on https://github.com/Pilloxa/react-native-nordic-dfu/pull/153 before I do so?

yannvanhalewyn commented 3 years ago

Version 3.2.1 has been released to npm with with these changes along with #153. Be vigilant and test this one to make sure everything is working!