Pilot-in / PiloPress

The most advanced WordPress Page Builder using Advanced Custom Fields & TailwindCSS
https://www.pilopress.com
62 stars 11 forks source link

Dont compile or load style-admin when CDN is enable #241

Open fgdaniel opened 1 year ago

fgdaniel commented 1 year ago

Describe the bug When we want to activate the tailwind css cdn option, then styles admin.min.css is loaded in the admin area

To Reproduce If the styles-admin.min.css file already exists in our theme

Expected behavior When we activate the tailwindcss option, we expect that the styles-admin.min.css file will no longer be loaded in the admin area, it will only be loaded if the tailwindcss option is deactivated, obviously remember that we have to build at the end after deactivating the option.

Screenshots screen 1 screen 2

WordPress, Plugins WordPress version: 6.2 Pilo'Press version: 0.4.3.2 ACF Pro version: 6.1.2 ACFE version: 0.8.9.3 ACF add-ons: None

NOTE: After we delete style-admin.min.css the option work as expected, good job!

barnemax-pilotin commented 1 year ago

Hi, thanks for the feedback.

We could but we would need to also enqueue the CDN in the admin area and add a admin_enqueue_scripts action and another function/tweak the existing one to handle the admin case (adding the admin prefix in the Tailwind config) (hook that loads the CDN in front) and toggle the filter pip/enqueue/admin/remove to true (here)

We would need to make some tests to see if there is no conflict between the CDN and the rest :)