search

PilzAdam / CertificateWatch

A Firefox add-on that warns about changing certificates
Apache License 2.0
10 stars 3 forks source link

Internal Error on every new tab when using URL mode #2

Open ghost opened 4 years ago

ghost commented 4 years ago

Hello and great addon,

Issue and reproduction: I'm having issues when using Certificate Watch in "URL mode", every new tab will have the red badge on the icon. Browser console and JS console don't show the error even when logging is enabled.

grafik

Thoughts and solutions: 1) Use different method than checking URL bar for 1st party domain to avoid errors?

Maybe you can isolate the 1st party domain like Gorhill does in uMatrix: https://github.com/gorhill/uMatrix/blob/master/src/js/matrix.js#L182

2) Please give a different option for storing certs than the existing ones! This is not meant to be negative, but URL mode is not great at all. I try to constructively explain why:

It would only store: www.example.com but not: images.example.com scripts.example.com

And the "all certificates mode" is even worse sadly: It will store certificates of advertisement networks, just literally everything. Overwhelming the user with reviewing hundreds of certificate changes a year.

I suggest 1st party + subdomains, which is basically: *.example.com

It is always okay to look into how uMatrix or uBlock isolate the 1st party + subdomain from a tab and re-purpose their code, it is free and open source and just asking to be re-used in other addons :) I think my suggestions will not be extraordinarily hard to implement. I'm no JS coder so bear with me that I cannot provide more help.

However it would already be good to prevent the "internal error" from happening on every new tab. Gladly will I try to log it for you. If I have to enter a specific addon debug mode to do so, i will provide more help. I am using latest Firefox 73 stable, official windows builds as of now.

Anything along the lines of this? about:debugging#/runtime/this-firefox tmp.log.DEBUG=true tmp.log.DEBUG=false

Kind greetings!

ghost commented 4 years ago

There is still an interest in seeing the error resolved if your own time allows for it. Thanks for your addon.

PilzAdam commented 4 years ago

Thanks for your feedback. Your ideas are good and I'd like to implement them. However, sadly I have currently no time for this add-on. I will fix this bug and implement your other ideas eventually, but please don't hold your breath. I'm sorry.

ghost commented 4 years ago

Take your time, I guess none of us imagined 2020 would turn out to be a year like this. Thanks for the status update though and maybe in a couple of months all will be easier.