search

PimDoos / kia_connect

Home Assistant Custom Component: MijnKia Connected Services
Apache License 2.0
8 stars 1 forks source link

Merge into kia_uvo #4

Open fuatakgun opened 2 years ago

fuatakgun commented 2 years ago

Do you think we can merge this work into Kia Uvo integration? As you might noticed, it supports Kia and Hyundai brands in multiple regions and this could be a perfect fit to expand into.

PimDoos commented 2 years ago

Sounds like a good plan! Although it should be noted this is not technically Kia UVO. The MijnKia version this integration is made for supports less features than the newer vehicles with UVO modems (no climate control, no remote start etc). I'll be happy to help integrating it into kia_uvo!

PimDoos commented 2 years ago

Since hacktoberfest is coming up, mind adding a hacktoberfest flag in your repo? I'll see if I can make some pulls to merge this into kia_uvo :)

cdnninja commented 1 year ago

Just ran into this and agree with fuatakgun. Would be happy to have this added to the list of supported car types. kia_uvo has turned into multiple kia/hyundai cars. We also have hyund which the hope was to become the base for version 2 of kia_uvo.

cdnninja commented 1 year ago

I have contributor support to the kia_uvo repo. Is it too late for the hacktoberfest flag to help you out?

PimDoos commented 1 year ago

I can give it a try this weekend, but I'm not sure whether I can pull it off within hacktober. Much of the base code (inspiration) came from the kia_uvo integration though, before I turned it into a fully async integration, so maybe some of the old sync versions will be easier to port.

I already completed hacktober though, so that's not a blocking issue for me :)