hexpatch test fails on wasm (emscripten)

PinNaCode / magiskboot_build

unofficial magiskboot build system (and port) targeting multi-platform (does not require NDK)

Apache License 2.0

150 stars 23 forks source link

hexpatch test fails on wasm (emscripten) #17

Closed ghost closed 8 months ago

ghost commented 9 months ago

hexpatch doesn't seem to change the input file at all

ghost commented 8 months ago

the issue seems to be related to shared read/write file mappings on emscripten, which is currently buggy (but mmap isn't really supported by wasi or anything, so i think its fair)

if the original fd (used to create file mapping) is closed before munmap, munmap will fail and any changes to the mapped memory view will be lost

ghost commented 8 months ago

fixed in https://github.com/ookiineko/magiskboot_build/commit/e15b74f9326f80d52e9c6d9736900afd88181840