search

Pinacolada64 / ImageBBS

A bulletin board system (BBS) for the Commodore 64.
15 stars 5 forks source link

VF - Watchdog files: nothing creates two of the three entries #12

Open Pinacolada64 opened 6 years ago

Pinacolada64 commented 6 years ago

e.zz log (local maint file) and e.nu log (blacklist logon file) aren't created/read from anywhere that I see. New routines will have to be written if we want these features.

e.em log (mail sent file) is created by im.misc2 and +.EM.

bucko219 commented 4 years ago

This was a leftover of my personal +.VF from 1.2, when I updated the +.VF for 2.0 I took my original because it had new features to it, but had to drop out of the programming team before I could finish the file and remove the Watchdog routines. Remove the routines, OR just add the routines to the files in question. +.EM, create a +.ZZ as I had, and +.lo for when a user is sent a forced mail deleting their account..

bucko219 commented 3 years ago

Just as an add on, this is all fixed in 3.0. I have added the zz log routines, and re-worked the em log routine. There still lies in this more room for expansion of add on logs you might want to look at that are not in the LG portion. Such as e.dx log which is a log of using the i.DE function of direct downloads. Or build a new user blacklist module by either ip address or handle. That is something I am considering to do in the near future after I finish a couple of other things..

Pinacolada64 commented 3 years ago

Cool.

There still lies in this more room for expansion of add on logs you might want to look at that are not in the LG portion.

That would be a good place to put that functionality.

Or build a new user blacklist module by either ip address or handle.

I think probably fail2ban would be a better solution to blacklist IP addresses from an "accessibility" perspective (if that makes sense; i.e., I don't know of a way to pass IP addresses from a TCP/IP bridge to the BBS). I don't have any experience with fail2ban, but @jonez734 does, or at least he brought it to my attention.

Blacklisting logon by handles might be an interesting feature, but really what's to stop a blacklisted user from receiving a message Your handle has been blacklisted from signing on., then signing up with a slightly different account name that isn't blacklisted? Blacklisted user JOHNDOE could sign on as JOHNDOE1, thus circumventing the blacklist (although it's ultimately up to the sysop to validate the user).

I was also pondering too how the list might be maintained. Was thinking using the "scan struct" (&,60,8) would be cool (would give us a good reason to learn/test how it works), but probably a SEQ file would be easiest.

Just some thoughts. Honestly, I'm all for adding it and maybe having a lightbar checkmark to toggle the feature's availability.

bucko219 commented 3 years ago

Agree about fail2ban, just wish I knew it better. That could be used as a basis of a blacklist sort of like the original did with the phone number. I agree about handles and whatnot, lets be honest in this day and age most people are not limiting access to anything! Just an idea tossed out there..