Pinacolada64 / NOW

A MUD under construction based on Evennia.
9 stars 8 forks source link

Welcome screen and Login screen #4

Open Pinacolada64 opened 7 years ago

Pinacolada64 commented 7 years ago

(this references file /server/conf/connection_screens.py)

A few issues I've been thinking of lately:

AmberFennek commented 7 years ago

@Pinacolada64 - A difference with the web client versus telnet client is line spacing, which causes the aspect ratio of the presentation. Telnet clients typically display text lines with no spacing between them.

A mechanism for presenting text in the <pre> tag styling would be required, perhaps sent to the web client as Out Of Band information, then interpreted in JavaScript, perhaps the same sort of mechanism as displaying a background image in the client when the character is visiting a specific room.

AmberFennek commented 7 years ago

@Pinacolada64 The distorted aspect of the webclient was solved by changing the line-spacing permanently, not just for the login screen.

But knowing that someone's logging in using the webclient, perhaps a different welcome screen can be offered.

AmberFennek commented 7 years ago

Different welcome screen placeholders exist now and work for Telnet/SSH versus webclient.

AmberFennek commented 6 years ago

@tricuspa

Tricuspa intones, "Oh and you aren't getting the new picture for NOW" Tricuspa intones, "tonight at least"

Ask @JeeDRGN what he thinks the optimal size is. We can accept and display raster or vector art in the webclient.

AmberFennek commented 6 years ago

@tricuspa

Thanks

Thank you for submitting this image for the welcome screen webclient image.

Issues

I want to expound upon the use of the word "issues" in github. It is meant to mean: noun sense 1. -- an important topic or problem for debate or discussion.

Problems are often an important topic, but important topics are not always problems. And certainly, I did not mean to imply that there is an issue with you, except in the sense that there is an important topic for debate or discussion with you inclusively, not meaning you are the topic of the issue, but you are included in discussing the issue.

Hardcoded URL, bad.

Now, as currently, the URL that includes the image in webclient is hardcoded here, which is admittedly bad practice. We should endeavor in the future to put such things in the settings database and refer to a particular database setting for welcome screens.

No notification of commits,

Also, another subject I want to touch on is that gitub does not give email notifications on commits, but does give them on "issues" updates here via: Notifications [Unsubscribe button] "You’re receiving notifications because you modified the open/close state." (upper right of this page). Sorry I did not notice your contribution earlier, but if you respond here, I and @Pinacolada64 get notifications.