search

PinataCloud / Pinata-SDK

Official SDK for the Pinata IPFS service
MIT License
273 stars 67 forks source link

PinataMetadata type is not matching SDK documentation #161

Closed Freezystem closed 5 months ago

Freezystem commented 12 months ago

Hi Pinata Dev Team !

The PinataMetadata type is not matching the metadata used throughout the SDK documentation.
See here and here for example.

The correct type would be something like:

export interface PinataMetadata {
    name?: string;
    keyvalues?: {
        [key: string]: string | number | null;
    }
}

I'm willing to make a PR if you want me to. 😇 Regards,

stevedylandev commented 5 months ago

Hey there! Thank you for this feedback, we are currently rewriting the SDK and will keep this in mind!