coderabbitai[bot]
commented
4 months ago [!WARNING]
Rate limit exceeded
@martijnvdbrug has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 6 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 03887c6a14c0885753b0e02091f3dcb94a0f9ff0 and 9b3c8198b916e1c7378cada29deecc2da0704d8b.
Walkthrough
The recent updates to the Vendure Picqer plugin enhance data synchronization by enabling immediate updates to Picqer when specific custom fields of product variants are altered. This includes the addition of a new configuration option to specify which custom fields should trigger synchronization, thereby improving data consistency and operational efficiency. Improvements in error handling, type safety, and logging practices further strengthen the robustness of the API client and service.
Changes
| Files | Change Summary |
|---|---|
CHANGELOG.md, README.md |
Updated changelog with new version 3.1.2 details; added shouldSyncOnProductVariantCustomFields property to README for custom field synchronization. |
eslint.config.js |
Introduced ESLint configuration, enhancing TypeScript linting capabilities. |
src/api/*.ts |
Improved type safety and error handling in picqer.client.ts, picqer.controller.ts, picqer.handler.ts, and picqer.service.ts. |
src/api/types.ts, src/picqer.plugin.ts |
Removed unused imports and added new shouldSyncOnProductVariantCustomFields property to PicqerOptions interface. |
src/ui/*.ts |
Enhanced type safety in picqer-config.component.ts and adjusted methods for better clarity and structure. |
test/picqer.spec.ts |
Modified tests to include synchronization of new custom field height and added test cases for validating synchronization behavior. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Automated synchronization for specific custom fields (#484) | ✅ | |
| Ensure changes in custom fields trigger immediate updates (#484) | ✅ |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
The changes in this PR implement and close #484
Breaking changes
Does this PR include any breaking changes we should be aware of? NO
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time:
📦 For publishable packages:
package.jsonCHANGELOG.mdSee this example