Picqer plugin: transition to Shipped first

Pinelab-studio / pinelab-vendure-plugins

Monorepo for different Vendure plugins developed by Pinelab

111 stars 49 forks source link

Picqer plugin: transition to Shipped first #504

Closed martijnvdbrug closed 2 months ago

martijnvdbrug commented 3 months ago

The Picqer plugin is transitioning orders to Delivered on incoming webhook, skipping the Shipping state. Most projects expect the order to go from Payment Settled to Shipped to Delivered.

[ ] Transition orders to Shipped before transitioning to Delivered (Line 401 in picqer.service.ts)
[ ] Publish a patch of plugin
[ ] Install patched version in the HPS project

dalyathan commented 2 months ago

On what OrderData.status should we transition to Shipped @martijnvdbrug ? processing?

martijnvdbrug commented 2 months ago

@dalyathan Good question. So, there is no new incoming webhook or OrderData.status needed. The problem is currently that the order transitions from PaymentSettled to Delivered directly, skipping the Shipped state (Line 401 in picqer.service.ts).

The underlying problem is that we are depending on an order status event in the project, and assume the order will at some point be in a Shipped state before being delivered.