chartist.component.ts typescript error when building the UI

[taxilian]

Which plugin/repository is the issue about? metrics

Describe the bug When trying to build the admin UI I get:

admin-ui/src/extensions/eb6e1994381aaf6a1ded134203bba73449900d8a1578974a2f65ce3958c246ad/chartist/chartist.component.ts(47,35): error TS2345: Argument of type 'undefined[] | ChartEntry' is not assignable to parameter of type 'ChartEntry'.
  Type 'undefined[]' is missing the following properties from type 'ChartEntry': summary, formatOptions
admin-ui/src/extensions/eb6e1994381aaf6a1ded134203bba73449900d8a1578974a2f65ce3958c246ad/chartist/chartist.component.ts(110,53): error TS2345: Argument of type 'undefined[] | ChartEntry' is not assignable to parameter of type 'ChartEntry'.
  Type 'undefined[]' is not assignable to type 'ChartEntry'.

To Reproduce Steps to reproduce the behavior:

Using Vendure 3.0.5 and typescript@5.3.3 trying to compile a custom admin UI.

Expected behavior No errors

Screenshots

Environment

• NodeJS version - v22.10.0
• Vendure version: 3.0.5
• Plugin version 1.3.1
• Database Postgres but not really applicable
• Any other version numbers from the environment you're using

typescript 5.3.3

Additional context

It is possible that there is something unusual about how I'm building my custom UI, but everything else has been working.

[taxilian]

Digging into the source code this looks like typescript is actually catching a real bug. The line is:

      this.chart.update(this.entriesToLineChartData(this.entries ?? []));

entriesToLineChartData takes a ChartEntry and immediately tries to use entry.summary?.labels?.length – since summary won't exist on an empty array this will technically work, but it's confusing at best. It would probably make more sense to have entriesToLineChartData aware that entry could be undefined, then always just pass in this.entries – which should also know that it could possibly be undefined.

[taxilian]

FWIW my tsconfig parameters are:

 {
   "compilerOptions": {
    "allowJs": true,
    "module": "CommonJS",
    "allowSyntheticDefaultImports": true,
    "esModuleInterop": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "ES2022",
    "useDefineForClassFields": false,
    "strict": false,
    "sourceMap": true,
    "outDir": "./dist",
    "baseUrl": "./",
    "resolveJsonModule": true,
    "strictPropertyInitialization": false,
    "skipLibCheck": true
  },
}