Closed martijnvdbrug closed 2 weeks ago
The changes in this pull request involve modifications to several files, primarily focusing on enhancing error handling and logging practices, refining test coverage for specific functions, and simplifying code structures. Notable adjustments include updates to ESLint configuration to ignore certain files, the addition of unit tests for the campaign-util
module, and improvements in the InvoiceService
class's methods for better error management and user input validation.
File | Change Summary |
---|---|
eslint-base.config.js |
Added **/src/ui/** to the ignores array to exclude UI files from linting checks. |
packages/vendure-plugin-campaign-tracker/src/services/campaign-util.spec.ts |
Introduced a test suite for calculateRevenuePerCampaign , validateAttributions , and isOlderThan functions, enhancing test coverage. |
packages/vendure-plugin-invoices/src/services/invoice.service.ts |
Refined error handling in generatePdfFile , updated downloadMultiple to limit downloads, and improved logging in createInvoicesForOrder . |
packages/vendure-plugin-primary-collection/src/util/export-primary-collections.ts |
Removed ProductPrimaryCollectionPartial type, simplified product query, and streamlined data access. |
packages/vendure-plugin-shipping-extensions/src/config/distance-based-shipping-calculator.ts |
Updated error handling in calculate method to use a specific Error type for better type safety. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Checklist
📌 Always:
👍 Most of the time:
📦 For publishable packages:
package.json
CHANGELOG.md
See this example