coderabbitai[bot]
commented
1 week ago [!CAUTION]
Review failed
The pull request is closed.
Walkthrough
The changes in this pull request involve modifications to the AcceptBluePlugin class, enhancing its configuration by adding nullable and readonly custom fields for OrderLine and Customer entities. The error handling in the acceptBluePaymentHandler has been improved to return a declined state instead of throwing errors. Additionally, new test cases for the getNrOfBillingCyclesLeft function have been added, and the billing cycle calculation logic has been refined. A new export statement has also been introduced to expand the public API.
Changes
| File Path | Change Summary |
|---|---|
packages/vendure-plugin-accept-blue/src/accept-blue-plugin.ts |
Updated import statement, modified static init return type, added custom fields with attributes. |
packages/vendure-plugin-accept-blue/src/api/accept-blue-handler.ts |
Enhanced createPayment method with try-catch for error handling. |
packages/vendure-plugin-accept-blue/src/index.ts |
Added export statement for custom-field-types. |
packages/vendure-plugin-accept-blue/src/util.spec.ts |
Introduced a test suite for getNrOfBillingCyclesLeft with multiple test cases. |
packages/vendure-plugin-accept-blue/src/util.ts |
Updated getNrOfBillingCyclesLeft and getDaysBetweenBillingCycles functions for improved logic. |
packages/vendure-plugin-accept-blue/vitest.config.js |
Modified test property to remove specific test file inclusion. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Accept Blue can accidently end up in an unwanted auto renew scenario (#532) | ✅ | |
| acceptBlueCustomerId should be nullable (#531) | ✅ | |
| acceptBlueCustomerId should be a readonly hidden customField (#519) | ✅ | |
| Accept Blue payment handler should return Declined instead of throwing (#493) | ✅ |
Possibly related PRs
- #458: Enhances webhook handling capabilities related to custom fields and events.
- #538: This PR includes similar modifications to the
AcceptBluePlugin, specifically making thecustomerIdfield nullable and readonly.
[!WARNING]
Rate limit exceeded
@martijnvdbrug has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 50 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.📥 Commits
Reviewing files that changed from the base of the PR and between 9961b9678a156db40571dfa41765822cf2322018 and 29b1c5c4312f6af201196473f7dd8b509474da7d.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Declinedwhen handling payment fails, instead of throwing. Closes #493Breaking changes
Checklist
📌 Always:
👍 Most of the time:
📦 For publishable packages:
package.jsonCHANGELOG.md