search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

chore(pingcap/tiproxy): delete the old cd jobs #2919

Closed wuhuizuo closed 2 months ago

wuhuizuo commented 2 months ago

now they are using new CD system to build.

Signed-off-by: wuhuizuo wuhuizuo@126.com

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that the author is deleting some old CD jobs since they are now using a new CD system to build. The diff shows that several files are being deleted, including the pipeline and pod configuration files for the old CD jobs.

Potential problems that I see with this PR are:

  1. Lack of context: The PR description is very brief and lacks context about why the old CD jobs are being deleted. It would be helpful to provide more information in the description or in a linked issue or document.

  2. Impact on existing CD workflows: It is possible that the deletion of these CD jobs could impact existing CD workflows. The author should ensure that any dependent workflows are updated accordingly.

  3. No testing information: It is not clear if the author has tested the changes in this PR. It would be helpful to include information about any testing that was done or any plans for testing.

As for fixing suggestions, here are some recommendations:

  1. Provide more context: Add more information to the PR description or link to a document or issue that explains why the old CD jobs are being deleted.

  2. Check for impacts on existing workflows: Review any dependent workflows and ensure that they are updated accordingly.

  3. Add testing information: Add information about any testing that was done or plans for testing, such as which environments were tested and what test cases were run.

ti-chi-bot[bot] commented 2 months ago

[LGTM Timeline notifier]

Timeline:

wuhuizuo commented 2 months ago

/approve

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[jobs/pingcap/tiproxy/cd/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/jobs/pingcap/tiproxy/cd/OWNERS)~~ [wuhuizuo] - ~~[pipelines/pingcap/tiproxy/cd/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/pingcap/tiproxy/cd/OWNERS)~~ [purelind,wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment