ti-chi-bot[bot]
commented
2 months ago I have already done a preliminary review for you, and I hope to help you do a better job.
From the pull request, it seems that the changes are focused on enabling the trigger for new tikv ut on lts branch. Specifically, the changes include:
- Updating the
pull_unit_test.groovyfiles for release 6.1, 6.5, 7.1, 7.5, and 8.1 to set the PR description usingprow.setPRDescription. - Adding new presubmits for release 6.5, 7.1, 7.5, and 8.1 in the
tikv-tikv-release-*.yamlfiles.
There are no major potential problems that I can identify in this pull request. However, it's important to note that the changes being made here are related to CI/CD and automation, so it's crucial to ensure that the new trigger is thoroughly tested before enabling status reporting and automatic triggering.
For fixing suggestions, I would suggest:
- Double-checking that the new presubmits added in the
tikv-tikv-release-*.yamlfiles are correctly formatted and that the branches specified are correct. - Testing the changes on a test environment before merging the pull request.
- After testing the new trigger, add a comment to the pull request indicating that it has been tested and is ready to be enabled.
Enable trigger for new tikv ut on lts branch. After a period of testing, we will enable status reporting and automatic triggering.