search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

chore(tiflash): revert to use llvm13 image on master #2921

Closed purelind closed 2 months ago

purelind commented 2 months ago

revert to use llvm13 image on master tiflash new ut pipeline.

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key change is that the image used for the runner container in the pod-merged_unit_test.yaml and pod-pull_unit-test.yaml files has been reverted to tiflash/tiflash-llvm13-amd64:v20231214 from hub.pingcap.net/tiflash/tiflash-llvm-base:amd64-llvm-17.0.6.

There doesn't seem to be any potential problems with this change as it is a simple image version update. However, it's always good to check if the new image version has any known issues or vulnerabilities.

As for suggestions, it would be great if the pull request description includes more details about why this change was made. Additionally, it would be great if the pull request is linked to an issue or a task so that it's easier to track the changes made to the codebase.

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[pipelines/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment