ti-chi-bot[bot]
commented
2 months ago I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the Pull Request title and description, it seems that the changes are related to fixing an issue with fetching Git type crates in the old CD pipeline.
The key change in the code is the addition of the line "export CARGO_NET_GIT_FETCH_WITH_CLI=true" in the "tikv" build step. This is a workaround to fix the issue with fetching Git type crates.
However, there are a few potential problems with this solution. Firstly, the Pull Request description does not provide any information on what caused the issue in the first place. Secondly, the solution of setting "CARGO_NET_GIT_FETCH_WITH_CLI=true" might have other unintended side effects.
To fix this issue, it would be better to investigate the root cause of the issue and find a more precise solution instead of using a workaround. This could involve updating the dependencies or configuration of the CD pipeline. Additionally, it would be helpful to add some documentation or comments explaining the issue and the solution in the code.
Overall, this Pull Request seems to be a temporary fix, and it would be better to find a more sustainable solution.
wuhuizuo
Ref: https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli Signed-off-by: wuhuizuo wuhuizuo@126.com