search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

chore(tikv): set retry to 5 on new ut on lts branch #2925

Open purelind opened 2 months ago

purelind commented 2 months ago

set retry to 5 on new ut on lts branch.

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from purelind, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pipelines/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request diff, it seems that the change only adds the --retries 5 argument to the EXTRA_NEXTEST_ARGS variable in the pull_unit_test.groovy file for three different release branches (release-6.5, release-7.1, and release-7.5) of the tikv repository.

There are no potential problems that I can see with this change. However, it would be good to make sure that the --retries option is supported by the testing framework being used.

As for fixing suggestions, it would be good to add some more context to the pull request description to explain why the retries are being added. Additionally, it might be helpful to add some comments in the code explaining the purpose of the --retries option and how it affects the testing process.