search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

fix(docs-tidb-operator): update build pdf script #2926

Closed purelind closed 2 months ago

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Key changes in this pull request include updating the build pdf script in the docs-tidb-operator pipeline by changing the find command to a grep command and updating the python3 script call.

A potential problem with this change is that the grep command may not work as expected since the pipeline is looking for tabs (\t) in the files, and the grep command is using the -P flag, which enables Perl-compatible regular expressions, to match the tabs. This may not be supported on all systems.

As a suggestion, it may be better to use a more standard regular expression to match tabs, such as grep -R $'\t' *. Additionally, it may be good to add comments explaining why the change was made and what the expected behavior is.

Overall, this seems like a simple change that should not cause any major issues, but it is important to ensure that the command works as expected on all systems before merging the pull request.

purelind commented 2 months ago

test link https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Fdocs-tidb-operator%2Fmerged_update/detail/merged_update/6/pipeline/

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[pipelines/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment