Closed Leavrth closed 2 months ago
I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the title and description of the PR, it seems that the change is related to using a different failpoint for integration testing in the tidb-server
binary. The change involves adding failpoint-enable
and failpoint-disable
to the make
command in the merged_integration_br_test.groovy
, pull_br_integration_test.groovy
, release-7.1/pull_br_integration_test.groovy
, release-7.5/pull_br_integration_test.groovy
, and release-8.1/pull_br_integration_test.groovy
files.
There are no potential problems with the change, as it seems to be a straightforward fix to use the correct failpoint for integration testing.
However, it might be a good idea to add some comments or documentation to explain why this change was necessary, and what impact it might have on the overall CI/CD pipeline.
As for fixing suggestions, it would be helpful to add some documentation to explain the change further. Additionally, it may be beneficial to test the changes locally before merging the PR to ensure that it works as expected.
/cc @BornChanger
Timeline:
2024-04-19 07:50:34.480217185 +0000 UTC m=+583653.591263630
: :ballot_box_with_check: agreed by purelind.[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: purelind
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Since https://github.com/pingcap/tidb/pull/52734, we need to use failpoint tidb-server for br integration test