PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

fix(br): use failpoint tidb-server instead #2928

Closed Leavrth closed 2 months ago

Leavrth commented 2 months ago

Since https://github.com/pingcap/tidb/pull/52734, we need to use failpoint tidb-server for br integration test

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description of the PR, it seems that the change is related to using a different failpoint for integration testing in the tidb-server binary. The change involves adding failpoint-enable and failpoint-disable to the make command in the merged_integration_br_test.groovy, pull_br_integration_test.groovy, release-7.1/pull_br_integration_test.groovy, release-7.5/pull_br_integration_test.groovy, and release-8.1/pull_br_integration_test.groovy files.

There are no potential problems with the change, as it seems to be a straightforward fix to use the correct failpoint for integration testing.

However, it might be a good idea to add some comments or documentation to explain why this change was necessary, and what impact it might have on the overall CI/CD pipeline.

As for fixing suggestions, it would be helpful to add some documentation to explain the change further. Additionally, it may be beneficial to test the changes locally before merging the PR to ensure that it works as expected.

purelind commented 2 months ago

/cc @BornChanger

ti-chi-bot[bot] commented 2 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pipelines/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/OWNERS)~~ [purelind] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment