search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

chore(dm): use target branch to downloda tidb binary #2929

Closed purelind closed 2 months ago

purelind commented 2 months ago

use target branch to downloda tidb binary, only support for qa-release-test trigger

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the main change in this pull request is to use the target branch to download the TiDB binary. The diff shows that the TIDB_BRANCH variable is now set to "${ghprbTargetBranch}" instead of "master".

There don't seem to be any potential problems with this change, as long as the target branch is correct and the TiDB binary can be downloaded successfully from that branch.

As a suggestion, it might be a good idea to add some comments in the code to explain what this change does and why it is necessary. This can help other developers who may be reviewing or modifying this code in the future.

Overall, this seems like a minor but useful change to simplify the process of downloading the TiDB binary for CI/CD pipelines.

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[jenkins/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/jenkins/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment