search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

increase ticdc pulsar integration test resource #2932

Closed sdojjy closed 2 months ago

sdojjy commented 2 months ago

ticdc pulsar integration test failed frequently, but when we run it on local env, it never fail, so this PR increase ticdc pulsar integration test resource.

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request is about increasing the resources for the tikdc pulsar integration test which is failing frequently. The change involves increasing the memory and CPU limits from 16Gi and 8 CPU to 32Gi and 16 CPU respectively.

There are no potential problems with this change, except that it could be expensive to run a test with such high resources. However, since the test is failing frequently, increasing the resources may help to stabilize it.

As a suggestion, it would be good to investigate why the test is failing frequently and try to fix the root cause of the issue. Also, it would be good to monitor the resource usage during the test to ensure that it doesn't exceed the available resources.

Overall, the change seems reasonable, and it is a good short-term solution to stabilize the test.

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pipelines/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/OWNERS)~~ [purelind] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 months ago

[LGTM Timeline notifier]

Timeline: