Open purelind opened 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from purelind, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:
This is a simple PR that updates the Docker-in-Docker (dind) image version in several YAML files. The new image version is "hub.pingcap.net/jenkins/docker:20.10.14-dind". Additionally, two environment variables have been added to the container definition, and a readiness probe has been defined to check the Docker daemon status.
Potential problems:
There are no major problems with this PR. However, there are some suggestions:
Fixing suggestions:
/hold
hub.pingcap.net/tiflash/tiflash-ci-base always restarting with those error
/usr/local/bin/../include/c++/v1/vector:1571: _LIBCPP_ASSERT '__n < size()' failed. vector[] index out of bounds
/usr/local/bin/../include/c++/v1/vector:1571: _LIBCPP_ASSERT '__n < size()' failed. vector[] index out of bounds
/usr/local/bin/../include/c++/v1/vector:1571: _LIBCPP_ASSERT '__n < size()' failed. vector[] index out of bounds
libc++abi: terminate_handler unexpectedly threw an exception
libc++abi: terminate_handler unexpectedly threw an exception
libc++abi: terminate_handler unexpectedly threw an exception
libc++abi: terminate_handler unexpectedly threw an exception
libc++abi: terminate_handler unexpectedly threw an exception
ref: #2820
Update dind image version. Avoid encountering this issue in the future https://github.com/docker-library/golang/issues/467