Closed Leavrth closed 5 months ago
I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, it seems that the changes were made to use the tidb server failpoint instead of the previous approach in some old CI. In the code diff, we can see that the changes are made in the br_ghpr_unit_and_integration_test.groovy
file.
The changes include updating the download link for the integration test artifact to use br_integration_test_failpoint.tar.gz
instead of br_integration_test.tar.gz
. Similarly, the command to build the tidb server has also been updated to include the failpoint-enable and failpoint-disable options.
These changes seem reasonable and should not cause any problems. However, it would be helpful to ensure that the new approach is tested and verified for any potential issues.
As a suggestion, it would be good to add some comments to the code explaining the changes and the reason behind them. Additionally, it would be good to update the pull request description with more details about the changes made and any testing done to verify the changes.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: purelind
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-04-23 04:29:19.946662078 +0000 UTC m=+61716.686564985
: :ballot_box_with_check: agreed by purelind.
use tidb server failpoint in old ci