search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

feat: enable report and trigger on tiflash master new pipeline #2943

Closed purelind closed 2 months ago

purelind commented 2 months ago

Enable report and trigger on tiflash master new pipeline.

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the information provided, it seems that the pull request is adding new pipeline triggers for the tiflash master branch. The changes include modifying the skip_report and optional fields to false, changing the context for the tests, and updating the trigger and rerun command for the tests.

One potential problem that I see is that the always_run field has been removed from both tests, which means that the tests will not run automatically on each pull request. This could result in delays in identifying issues with the code changes.

To fix this, the always_run field should be added back with a value of true so that the tests run automatically on every pull request.

Another suggestion is to provide more context about why these changes are needed and what benefits they bring. This can help reviewers better understand the purpose of the pull request and make more informed decisions during the review process.

purelind commented 2 months ago

/hold

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[prow-jobs/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/prow-jobs/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
purelind commented 2 months ago

/unhold