PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

feat: disable old pipeline trigger on tiflash master #2944

Closed purelind closed 2 months ago

purelind commented 2 months ago

disable old pipeline trigger on tiflash master.

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are related to disabling the old pipeline trigger on tiflash master. The actual changes in the code seem to add a blacklist for the master branch in three different Jenkins jobs.

The potential problem that I can see is that the pull request description and the actual code changes do not fully match. It is not clear from the pull request description why the blacklist is being added to these Jenkins jobs. Additionally, there is no explanation of what impact this change will have on the pipeline.

To address these issues, the pull request description could be updated to provide more context about why the blacklist is being added. Additionally, it might be helpful to add a comment in the code explaining the purpose of the blacklist.

As for fixing suggestions, it might be helpful to update the pull request description to explain the purpose of the changes in the code. Additionally, adding a comment in the code to explain the purpose of the blacklist would be helpful.

purelind commented 2 months ago

/hold

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[jenkins/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/jenkins/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 months ago

[LGTM Timeline notifier]

Timeline:

purelind commented 2 months ago

/unhold