fix(pingcap/ng-monitoring): fix the base_ref arg for create pull request on pingcap/monitoring

[wuhuizuo]

Signed-off-by: wuhuizuo wuhuizuo@126.com

[ti-chi-bot[bot]]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the change is to fix the base_ref argument for creating a pull request on the pingcap/monitoring repository. The change modifies the prow-jobs/pingcap-ng-monitoring-postsubmits.yaml file by replacing main with master in one place and changing base_ref to sub_ref in another.

Potential problems that I can see in this pull request are:

• It is not clear why the change is made. The pull request description does not provide any explanation, which could cause confusion for future maintainers.
• The base_ref argument is replaced with sub_ref in one place, but not in the other. This inconsistency could lead to issues in the future.
• It is not clear if any testing or verification was done for this change.

To fix these issues, I suggest the following:

• Update the pull request description to provide more context for the change.
• Replace base_ref with sub_ref consistently in both places.
• Verify the change by running tests and ensuring that the pull request is created as expected.

Overall, this change seems relatively straightforward, but it is important to ensure that it is well-documented and tested to avoid introducing issues in the future.

[ti-chi-bot[bot]]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the change is fixing an issue with the base_ref argument in the create pull request command in the pingcap/monitoring repository. The changes in the pull request are modifying the pingcap-ng-monitoring-postsubmits.yaml file to update the base_ref argument to master instead of main. Additionally, the pull request updates the image version of denoland/deno from 1.41.0 to 1.42.4.

One potential problem with this change is that it might break any existing workflows that rely on the base_ref argument being set to main. If the main branch is the default branch for the pingcap/monitoring repository, it might also cause confusion for other contributors who are used to seeing the main branch being used as the base reference.

To fix this, it might be better to update the base_ref argument to a variable that can be set externally, rather than hardcoding it to master. Additionally, it might be helpful to add a comment in the code explaining the reason for the change, to avoid confusion for future contributors.

Overall, the changes seem straightforward and should not introduce any significant issues, as long as the base_ref argument is properly tested and validated before merging the pull request.

[wuhuizuo]

/approve

[ti-chi-bot[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow-jobs/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/prow-jobs/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment